[
https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307284#comment-17307284
]
ASF subversion and git services commented on LUCENE-9856:
---------------------------------------------------------
Commit 945b1cb8726223d5b0d5f61e85174ca93931b86e in lucene's branch
refs/heads/main from Robert Muir
[ https://gitbox.apache.org/repos/asf?p=lucene.git;h=945b1cb ]
LUCENE-9856: fail precommit on unused local variables, take two (#37)
Enable ecj unused local variable, private instance and method detection. Allow
SuppressWarnings("unused") to disable unused checks (e.g. for generated code or
very special tests). Fix gradlew regenerate for python 3.9
SuppressWarnings("unused") for generated javacc and jflex code. Enable a few
other easy ecj checks such as Deprecated annotation, hashcode/equals, equals
across different types.
Co-authored-by: Mike McCandless <mikemcc...@apache.org>
> Improve static analysis to catch dead code and other potential bugs
> -------------------------------------------------------------------
>
> Key: LUCENE-9856
> URL: https://issues.apache.org/jira/browse/LUCENE-9856
> Project: Lucene - Core
> Issue Type: Improvement
> Components: general/build
> Reporter: Zach Chen
> Priority: Minor
> Labels: build
> Fix For: main (9.0)
>
> Attachments: LUCENE-9856.patch
>
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> When working on PR [https://github.com/apache/lucene/pull/25,] we noticed
> that some dead code is not being caught during static analysis in gradle
> build, such as the *start* variable in the following code:
> [https://github.com/apache/lucene/blob/a5996dbecd4a6b4147d961260711a2cb6aeab3d3/lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java#L446-L456]
>
> We may need to look at if additional javac compiler flag, or configuration
> for *error prone,* should be added to catch such bug as well as other
> potential ones.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
