uschindler commented on a change in pull request #34:
URL: https://github.com/apache/lucene/pull/34#discussion_r599514548



##########
File path: 
lucene/analysis/common/src/test/org/apache/lucene/analysis/cjk/TestCJKBigramFilterFactory.java
##########
@@ -56,11 +56,10 @@ public void testHanOnlyUnigrams() throws Exception {
 
   /** Test that bogus arguments result in exception */
   public void testBogusArguments() throws Exception {
-    IllegalArgumentException expected =

Review comment:
       Obviously it comes from copy'n'paste = shit'n'waste. We have many places 
in code where the exception's message is checked. Code like this one here does 
not do it. Because this syntax with the lambda for exception checking was "new" 
at this point in time lot of people shit'n'wasted. 😱




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to