rmuir commented on a change in pull request #34:
URL: https://github.com/apache/lucene/pull/34#discussion_r599486860
##########
File path: lucene/core/src/test/org/apache/lucene/search/TestTotalHits.java
##########
@@ -22,6 +22,7 @@
public class TestTotalHits extends LuceneTestCase {
+ @SuppressWarnings("unlikely-arg-type")
Review comment:
This one detects `equals(typeA, typeB)` where typeA is different than
typeB.
In `src/java` every single thing it found was a bug (fixed in this PR).
Stuff like code calling equals(BytesRefBuilder, BytesRef), which probably was
broken during a refactoring.
In `src/test` it also found similar bugs. But there are a few tests that
intentionally do something like `assertFalse(myObj.equals("a string or
something"))` to test their `equals` method on a different class.
only a few tests needed the suppression, so I just added it to those equals
tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]