[GitHub] [lucene-solr] mocobeta commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects

2020-03-30 Thread GitBox
mocobeta commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects URL: https://github.com/apache/lucene-solr/pull/1388#discussion_r400682318 ## File path: gradle/render-javadoc.gradle ## @@ -15,93

[jira] [Commented] (SOLR-14374) Use coreLoadExecutor to load all cores; not just startup

2020-03-30 Thread Shalin Shekhar Mangar (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071421#comment-17071421 ] Shalin Shekhar Mangar commented on SOLR-14374: -- [~dsmiley] - yes that makes

[jira] [Commented] (SOLR-12028) BadApple and AwaitsFix annotations usage

2020-03-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071370#comment-17071370 ] ASF subversion and git services commented on SOLR-12028: Commit 1

[jira] [Commented] (SOLR-12028) BadApple and AwaitsFix annotations usage

2020-03-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071362#comment-17071362 ] ASF subversion and git services commented on SOLR-12028: Commit 1

[jira] [Commented] (SOLR-14014) Allow Solr to start with Admin UI disabled

2020-03-30 Thread Marcus Eagan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071336#comment-17071336 ] Marcus Eagan commented on SOLR-14014: - I wrote some code to try to help out. When som

[GitHub] [lucene-solr] MarcusSorealheis opened a new pull request #1391: SOLR-14014 Add a disable Admin UI Flag

2020-03-30 Thread GitBox
MarcusSorealheis opened a new pull request #1391: SOLR-14014 Add a disable Admin UI Flag URL: https://github.com/apache/lucene-solr/pull/1391 # Description I added a system property to allow users to disable the Solr Admin UI on start. # Solution I added t

[GitHub] [lucene-solr] HoustonPutman commented on a change in pull request #1387: SOLR-14210: Include replica health in healtcheck handler

2020-03-30 Thread GitBox
HoustonPutman commented on a change in pull request #1387: SOLR-14210: Include replica health in healtcheck handler URL: https://github.com/apache/lucene-solr/pull/1387#discussion_r400326049 ## File path: solr/core/src/test/org/apache/solr/handler/admin/HealthCheckHandlerTest.java

[GitHub] [lucene-solr] HoustonPutman commented on a change in pull request #1387: SOLR-14210: Include replica health in healtcheck handler

2020-03-30 Thread GitBox
HoustonPutman commented on a change in pull request #1387: SOLR-14210: Include replica health in healtcheck handler URL: https://github.com/apache/lucene-solr/pull/1387#discussion_r400326019 ## File path: solr/core/src/java/org/apache/solr/handler/admin/HealthCheckHandler.java ###

[GitHub] [lucene-solr] HoustonPutman commented on a change in pull request #1387: SOLR-14210: Include replica health in healtcheck handler

2020-03-30 Thread GitBox
HoustonPutman commented on a change in pull request #1387: SOLR-14210: Include replica health in healtcheck handler URL: https://github.com/apache/lucene-solr/pull/1387#discussion_r400328341 ## File path: solr/core/src/java/org/apache/solr/handler/admin/HealthCheckHandler.java ###

[jira] [Assigned] (SOLR-14210) Introduce Node-level status handler for replicas

2020-03-30 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl reassigned SOLR-14210: -- Assignee: Jan Høydahl > Introduce Node-level status handler for replicas > ---

[jira] [Commented] (SOLR-14374) Use coreLoadExecutor to load all cores; not just startup

2020-03-30 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071310#comment-17071310 ] David Smiley commented on SOLR-14374: - Does this make sense to you [~shalin] or anyon

[GitHub] [lucene-solr] mayya-sharipova commented on issue #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-03-30 Thread GitBox
mayya-sharipova commented on issue #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#issuecomment-606259561 @msokolov Sorry again for reporting incorrect benchmarking results. Below are are my latest results, and I feel q

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data

2020-03-30 Thread GitBox
tflobbe commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r400496145 ## File path: solr/core/src/test/org/apache/solr/handler/admin/ZookeeperReadTest.java ## @@ -

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data

2020-03-30 Thread GitBox
tflobbe commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r400494981 ## File path: solr/core/src/test/org/apache/solr/handler/admin/ZookeeperStatusHandlerTest.java ###

[jira] [Commented] (LUCENE-9266) ant nightly-smoke fails due to presence of build.gradle

2020-03-30 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071282#comment-17071282 ] Dawid Weiss commented on LUCENE-9266: - Seems like we can keep it in the repository (

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data

2020-03-30 Thread GitBox
tflobbe commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r400494393 ## File path: solr/core/src/java/org/apache/solr/handler/admin/ZkRead.java ## @@ -0,0 +1,117 @

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data

2020-03-30 Thread GitBox
tflobbe commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r400493916 ## File path: solr/core/src/java/org/apache/solr/handler/admin/ZkRead.java ## @@ -0,0 +1,117 @

[GitHub] [lucene-solr] tflobbe commented on issue #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data

2020-03-30 Thread GitBox
tflobbe commented on issue #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#issuecomment-606249273 @noblepaul, seems to me that there are still some unaddressed comments --

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

2020-03-30 Thread GitBox
jpountz commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1294#discussion_r400490859 ## File path: lucene/core/src/test/org/apache/lucene/search/TestIndexSearcher.java ###

[jira] [Commented] (SOLR-13579) Create resource management API

2020-03-30 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071278#comment-17071278 ] David Smiley commented on SOLR-13579: - Does it make sense for the resource management

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

2020-03-30 Thread GitBox
jpountz commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1294#discussion_r400483056 ## File path: lucene/core/src/java/org/apache/lucene/search/QueueSizeBasedExecutor.jav

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

2020-03-30 Thread GitBox
jpountz commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1294#discussion_r400489607 ## File path: lucene/core/src/test/org/apache/lucene/search/TestIndexSearcher.java ###

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

2020-03-30 Thread GitBox
jpountz commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1294#discussion_r400491077 ## File path: lucene/core/src/test/org/apache/lucene/search/TestIndexSearcher.java ###

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

2020-03-30 Thread GitBox
jpountz commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1294#discussion_r400490515 ## File path: lucene/core/src/test/org/apache/lucene/search/TestIndexSearcher.java ###

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

2020-03-30 Thread GitBox
jpountz commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1294#discussion_r400480289 ## File path: lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java ###

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

2020-03-30 Thread GitBox
jpountz commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1294#discussion_r400486985 ## File path: lucene/core/src/java/org/apache/lucene/search/SliceExecutor.java ###

[jira] [Assigned] (SOLR-14371) Zk StatusHandler should know about dynamic zk config

2020-03-30 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl reassigned SOLR-14371: -- Assignee: Jan Høydahl > Zk StatusHandler should know about dynamic zk config > ---

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source

2020-03-30 Thread GitBox
dweiss commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source URL: https://github.com/apache/lucene-solr/pull/1390#discussion_r400489677 ## File path: .github/workflows/gradle-precommit.yml ## @@ -19,5 +19,8 @@ jobs: java-ve

[jira] [Commented] (SOLR-14216) Exclude HealthCheck from authentication

2020-03-30 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071277#comment-17071277 ] Jan Høydahl commented on SOLR-14216: What about a new env.var to handle this: {noform

[jira] [Commented] (LUCENE-9266) ant nightly-smoke fails due to presence of build.gradle

2020-03-30 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071275#comment-17071275 ] Dawid Weiss commented on LUCENE-9266: - Right... but this policy isn't respected even

[GitHub] [lucene-solr] madrob commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source

2020-03-30 Thread GitBox
madrob commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source URL: https://github.com/apache/lucene-solr/pull/1390#discussion_r400487392 ## File path: build.gradle ## @@ -54,6 +55,7 @@ ext { // if the build file is incorrectly writt

[GitHub] [lucene-solr] madrob commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source

2020-03-30 Thread GitBox
madrob commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source URL: https://github.com/apache/lucene-solr/pull/1390#discussion_r400486453 ## File path: .github/workflows/gradle-precommit.yml ## @@ -19,5 +19,8 @@ jobs: java-ve

[jira] [Commented] (LUCENE-9266) ant nightly-smoke fails due to presence of build.gradle

2020-03-30 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071267#comment-17071267 ] Mike Drob commented on LUCENE-9266: --- On including gradle wrapper jar in our source rel

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source

2020-03-30 Thread GitBox
dweiss commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source URL: https://github.com/apache/lucene-solr/pull/1390#discussion_r400482408 ## File path: build.gradle ## @@ -54,6 +55,7 @@ ext { // if the build file is incorrectly writt

[GitHub] [lucene-solr] madrob commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source

2020-03-30 Thread GitBox
madrob commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source URL: https://github.com/apache/lucene-solr/pull/1390#discussion_r400482417 ## File path: build.gradle ## @@ -54,6 +55,7 @@ ext { // if the build file is incorrectly writt

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source

2020-03-30 Thread GitBox
dweiss commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source URL: https://github.com/apache/lucene-solr/pull/1390#discussion_r400481056 ## File path: build.gradle ## @@ -54,6 +55,7 @@ ext { // if the build file is incorrectly writt

[GitHub] [lucene-solr] madrob commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source

2020-03-30 Thread GitBox
madrob commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source URL: https://github.com/apache/lucene-solr/pull/1390#discussion_r400472030 ## File path: gradlew ## @@ -80,6 +80,19 @@ case "`uname`" in ;; esac + +# Loop in case

[jira] [Commented] (SOLR-8030) Transaction log does not store the update chain (or req params?) used for updates

2020-03-30 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071248#comment-17071248 ] David Smiley commented on SOLR-8030: Thanks; I filed SOLR-14375. I can see you are us

[jira] [Created] (SOLR-14375) AtomicUpdateDocumentMerger should allow fields not in the schema

2020-03-30 Thread David Smiley (Jira)
David Smiley created SOLR-14375: --- Summary: AtomicUpdateDocumentMerger should allow fields not in the schema Key: SOLR-14375 URL: https://issues.apache.org/jira/browse/SOLR-14375 Project: Solr

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source

2020-03-30 Thread GitBox
dweiss commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source URL: https://github.com/apache/lucene-solr/pull/1390#discussion_r400459182 ## File path: build.gradle ## @@ -54,6 +55,7 @@ ext { // if the build file is incorrectly writt

[GitHub] [lucene-solr] madrob commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source

2020-03-30 Thread GitBox
madrob commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source URL: https://github.com/apache/lucene-solr/pull/1390#discussion_r400454342 ## File path: build.gradle ## @@ -54,6 +55,7 @@ ext { // if the build file is incorrectly writt

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source

2020-03-30 Thread GitBox
dweiss commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source URL: https://github.com/apache/lucene-solr/pull/1390#discussion_r400453166 ## File path: .github/workflows/gradle-precommit.yml ## @@ -19,5 +19,8 @@ jobs: java-ve

[GitHub] [lucene-solr] madrob commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source

2020-03-30 Thread GitBox
madrob commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source URL: https://github.com/apache/lucene-solr/pull/1390#discussion_r400452053 ## File path: .github/workflows/gradle-precommit.yml ## @@ -19,5 +19,8 @@ jobs: java-ve

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source

2020-03-30 Thread GitBox
dweiss commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source URL: https://github.com/apache/lucene-solr/pull/1390#discussion_r400450439 ## File path: gradlew ## @@ -80,6 +80,19 @@ case "`uname`" in ;; esac + +# Loop in case

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source

2020-03-30 Thread GitBox
dweiss commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source URL: https://github.com/apache/lucene-solr/pull/1390#discussion_r400450976 ## File path: gradlew ## @@ -80,6 +80,19 @@ case "`uname`" in ;; esac + +# Loop in case

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source

2020-03-30 Thread GitBox
dweiss commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source URL: https://github.com/apache/lucene-solr/pull/1390#discussion_r400448369 ## File path: build.gradle ## @@ -54,6 +55,7 @@ ext { // if the build file is incorrectly writt

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source

2020-03-30 Thread GitBox
dweiss commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source URL: https://github.com/apache/lucene-solr/pull/1390#discussion_r400447186 ## File path: .github/workflows/gradle-precommit.yml ## @@ -19,5 +19,8 @@ jobs: java-ve

[GitHub] [lucene-solr] madrob opened a new pull request #1390: LUCENE-9266 remove gradle wrapper jar from source

2020-03-30 Thread GitBox
madrob opened a new pull request #1390: LUCENE-9266 remove gradle wrapper jar from source URL: https://github.com/apache/lucene-solr/pull/1390 ASF Release Policy states that we cannot have binary JAR files checked in to our source releases, a few other projects have solved this by mod

[jira] [Created] (SOLR-14374) Use coreLoadExecutor to load all cores; not just startup

2020-03-30 Thread David Smiley (Jira)
David Smiley created SOLR-14374: --- Summary: Use coreLoadExecutor to load all cores; not just startup Key: SOLR-14374 URL: https://issues.apache.org/jira/browse/SOLR-14374 Project: Solr Issue Typ

[jira] [Commented] (SOLR-8030) Transaction log does not store the update chain (or req params?) used for updates

2020-03-30 Thread Eugene Tenkaev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071106#comment-17071106 ] Eugene Tenkaev commented on SOLR-8030: -- [~dsmiley] sorry don't have it, but this erro

[jira] [Commented] (SOLR-13132) Improve JSON "terms" facet performance when sorted by relatedness

2020-03-30 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071103#comment-17071103 ] Michael Gibney commented on SOLR-13132: --- Quick prose follow-up to March 16 patch ve

[jira] [Commented] (SOLR-14170) Tag package feature as experimental

2020-03-30 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071068#comment-17071068 ] Jan Høydahl commented on SOLR-14170: bq. Jan Høydahl, take a prior deep breath the ne

[GitHub] [lucene-solr] msokolov commented on issue #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-03-30 Thread GitBox
msokolov commented on issue #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#issuecomment-606047977 @mayya-sharipova sounds good - I'd also encourage you to post a PR with your modifications to luceneutil

[GitHub] [lucene-solr] mayya-sharipova edited a comment on issue #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-03-30 Thread GitBox
mayya-sharipova edited a comment on issue #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#issuecomment-605327672 Update: these are wrong results. Please disregard them @msokolov Thank for suggesting additional

[GitHub] [lucene-solr] mayya-sharipova commented on issue #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-03-30 Thread GitBox
mayya-sharipova commented on issue #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#issuecomment-606042901 @msokolov Thank you for an additional review. I realized I ran benchmarks incorrectly, not indexing documents wit

[jira] [Commented] (SOLR-8030) Transaction log does not store the update chain (or req params?) used for updates

2020-03-30 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071019#comment-17071019 ] David Smiley commented on SOLR-8030: bq. Not able to do this, since I will receive err

[GitHub] [lucene-solr] janhoy commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data

2020-03-30 Thread GitBox
janhoy commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r400212137 ## File path: solr/core/src/java/org/apache/solr/handler/admin/ZookeeperReadAPI.java ## @@ -0,

[GitHub] [lucene-solr] janhoy commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data

2020-03-30 Thread GitBox
janhoy commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r400209923 ## File path: solr/core/src/java/org/apache/solr/handler/admin/ZookeeperReadAPI.java ## @@ -0,

[GitHub] [lucene-solr] janhoy commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data

2020-03-30 Thread GitBox
janhoy commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r400214021 ## File path: solr/core/src/java/org/apache/solr/handler/admin/ZookeeperReadAPI.java ## @@ -0,

[GitHub] [lucene-solr] janhoy commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data

2020-03-30 Thread GitBox
janhoy commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r400202098 ## File path: solr/core/src/java/org/apache/solr/security/PermissionNameProvider.java ## @@ -3

[jira] [Commented] (SOLR-10182) Backout directory metrics collection that caused performance degradation

2020-03-30 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17070981#comment-17070981 ] David Smiley commented on SOLR-10182: - Just an observation as I stumble over the code

[GitHub] [lucene-solr] janhoy commented on issue #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data

2020-03-30 Thread GitBox
janhoy commented on issue #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#issuecomment-606007576 Make sure to announce your intention in the JIRA issue too, and allow a few days lazy consensus.

[jira] [Comment Edited] (SOLR-8030) Transaction log does not store the update chain (or req params?) used for updates

2020-03-30 Thread Eugene Tenkaev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17070927#comment-17070927 ] Eugene Tenkaev edited comment on SOLR-8030 at 3/30/20, 12:24 PM: ---

[jira] [Commented] (SOLR-8030) Transaction log does not store the update chain (or req params?) used for updates

2020-03-30 Thread Eugene Tenkaev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17070927#comment-17070927 ] Eugene Tenkaev commented on SOLR-8030: -- {quote} Yes, you could do something like that

[GitHub] [lucene-solr] noblepaul commented on issue #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data

2020-03-30 Thread GitBox
noblepaul commented on issue #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#issuecomment-605881156 I plan to commit this soon This is an automated message from t

[jira] [Commented] (SOLR-14170) Tag package feature as experimental

2020-03-30 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17070809#comment-17070809 ] Ishan Chattopadhyaya commented on SOLR-14170: - [~janhoy], take a prior deep b

[jira] [Updated] (LUCENE-9298) Incorrect method 'clearDeletedDocIds' in BufferedUpdates

2020-03-30 Thread yubinglei (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yubinglei updated LUCENE-9298: -- Summary: Incorrect method 'clearDeletedDocIds' in BufferedUpdates (was: Incorrect clear order in Buff

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-03-30 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17070800#comment-17070800 ] Dawid Weiss commented on LUCENE-9278: - Thanks for chipping at this, [~tomoko]. > Ma

[jira] [Commented] (SOLR-14170) Tag package feature as experimental

2020-03-30 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17070797#comment-17070797 ] Noble Paul commented on SOLR-14170: --- bq."Not yet recommended for production use" Why d

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects

2020-03-30 Thread GitBox
dweiss commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects URL: https://github.com/apache/lucene-solr/pull/1388#discussion_r400021617 ## File path: gradle/render-javadoc.gradle ## @@ -15,93 +1

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects

2020-03-30 Thread GitBox
dweiss commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects URL: https://github.com/apache/lucene-solr/pull/1388#discussion_r400022817 ## File path: gradle/render-javadoc.gradle ## @@ -15,93 +1

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects

2020-03-30 Thread GitBox
dweiss commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects URL: https://github.com/apache/lucene-solr/pull/1388#discussion_r400021181 ## File path: gradle/render-javadoc.gradle ## @@ -15,93 +1

[jira] [Commented] (SOLR-14373) HDFS block cache allows overallocation

2020-03-30 Thread Istvan Farkas (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17070787#comment-17070787 ] Istvan Farkas commented on SOLR-14373: -- Started working on this, will submit a patch

[jira] [Created] (SOLR-14373) HDFS block cache allows overallocation

2020-03-30 Thread Istvan Farkas (Jira)
Istvan Farkas created SOLR-14373: Summary: HDFS block cache allows overallocation Key: SOLR-14373 URL: https://issues.apache.org/jira/browse/SOLR-14373 Project: Solr Issue Type: Bug Sec

[GitHub] [lucene-solr] janhoy commented on a change in pull request #1387: SOLR-14210: Include replica health in healtcheck handler

2020-03-30 Thread GitBox
janhoy commented on a change in pull request #1387: SOLR-14210: Include replica health in healtcheck handler URL: https://github.com/apache/lucene-solr/pull/1387#discussion_r49116 ## File path: solr/core/src/java/org/apache/solr/handler/admin/HealthCheckHandler.java ##

[jira] [Commented] (SOLR-14170) Tag package feature as experimental

2020-03-30 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17070755#comment-17070755 ] Jan Høydahl commented on SOLR-14170: So why did you assign yourself to this JIRA Janu

[jira] [Commented] (SOLR-14356) PeerSync with hanging nodes

2020-03-30 Thread Lucene/Solr QA (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17070744#comment-17070744 ] Lucene/Solr QA commented on SOLR-14356: --- | (x) *{color:red}-1 overall{color}* | \\

[jira] [Commented] (LUCENE-9289) Speed up Levenshtein distance calculation when we don't need the exact distance

2020-03-30 Thread Andras Salamon (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17070736#comment-17070736 ] Andras Salamon commented on LUCENE-9289: [~jpountz] I haven't measured the speed