dweiss commented on a change in pull request #1390: LUCENE-9266 remove gradle
wrapper jar from source
URL: https://github.com/apache/lucene-solr/pull/1390#discussion_r400489677
##########
File path: .github/workflows/gradle-precommit.yml
##########
@@ -19,5 +19,8 @@ jobs:
java-version: 11
- name: Grant execute permission for gradlew
run: chmod +x gradlew
+ - name: Run something to download the gradle wrapper jar
Review comment:
The checksum should be checked as part of the script that downloads the
wrapper jar... otherwise it's too late and you've executed something you
shouldn't have. That's what I meant when I said it adds additional complexity...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
