madrob commented on a change in pull request #1390: LUCENE-9266 remove gradle
wrapper jar from source
URL: https://github.com/apache/lucene-solr/pull/1390#discussion_r400487392
##########
File path: build.gradle
##########
@@ -54,6 +55,7 @@ ext {
// if the build file is incorrectly written and evaluates something
// eagerly).
+apply from: file('gradle/wrapper.gradle')
Review comment:
I see we found the same things here.
The other option is to exclude the gradle-wrapper from failing the smoke
check? I don't want to take the position that because other projects are doing
something which is against apache policy (and we even have a check for it!)
that it's ok for us to do so as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
