janhoy commented on a change in pull request #1327: SOLR-13942:
/api/cluster/zk/* to fetch raw ZK data
URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r400202098
##########
File path:
solr/core/src/java/org/apache/solr/security/PermissionNameProvider.java
##########
@@ -38,6 +38,7 @@
COLL_READ_PERM("collection-admin-read", null),
CORE_READ_PERM("core-admin-read", null),
CORE_EDIT_PERM("core-admin-edit", null),
+ ZK_READ_PERM("zk-read", null),
Review comment:
I cannot see that this new permission is used anywhere?
And if the new zk handler is covered by `zk-read`, should not also existing
`ZookeeperInfoHandler` handler implement PermissionNameProvider and declare the
same permission, for consistency?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
