[ 
https://issues.apache.org/jira/browse/SOLR-14374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071310#comment-17071310
 ] 

David Smiley commented on SOLR-14374:
-------------------------------------

Does this make sense to you [~shalin] or anyone else?  I'll try this out and 
submit a PR tonight.

> Use coreLoadExecutor to load all cores; not just startup
> --------------------------------------------------------
>
>                 Key: SOLR-14374
>                 URL: https://issues.apache.org/jira/browse/SOLR-14374
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Major
>
> CoreContainer.load() creates coreLoadExecutor (an Executor) to load 
> pre-existing cores concurrently -- defaulting to 8 at a time.  Then it's 
> never used again.  However, cores might be loaded in other circumstances: (a) 
> creating new cores, (b) "transient" cores, or (c) loadOnStartup=false cores, 
> (d) reload cores.  By using coreLoadExecutor for all cases, we'll then have 
> metrics for core loading that work globally and not just on startup since 
> coreLoadExecutor is instrumented already -- 
> {{CONTAINER.threadPool.coreLoadExecutor}} metrics path.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to