HoustonPutman commented on a change in pull request #1387: SOLR-14210: Include
replica health in healtcheck handler
URL: https://github.com/apache/lucene-solr/pull/1387#discussion_r400326049
##########
File path:
solr/core/src/test/org/apache/solr/handler/admin/HealthCheckHandlerTest.java
##########
@@ -177,4 +183,13 @@ public void testHealthCheckV2Api() throws Exception {
}
}
+ @Test
+ public void testFindUnhealthyCores() throws Exception {
+ ZkStateReader reader =
ClusterStateMockUtil.buildClusterState("csrr2rDcsr2rR", 1, 1, "node1", "node2");
Review comment:
probably easier to use this in a try with resources block, so that it closes
even if something fails.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
