Re: [I] About /v1/config REST API endpoint [iceberg]

2024-03-08 Thread via GitHub
nastra commented on issue #9880: URL: https://github.com/apache/iceberg/issues/9880#issuecomment-1985238077 The `warehouse` query parameter for that endpoint refers to https://github.com/apache/iceberg/blob/5b84f34a5386fc61b17bfe7dc7c1cbe565550958/core/src/main/java/org/apache/iceberg/rest/R

Re: [PR] Feature make oauth `audience` configurable [iceberg]

2024-03-08 Thread via GitHub
nastra commented on code in PR #9839: URL: https://github.com/apache/iceberg/pull/9839#discussion_r1517380056 ## core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java: ## @@ -394,20 +430,24 @@ public static class AuthSession { private volatile boolean keepRefreshe

Re: [PR] Feature make oauth `audience` configurable [iceberg]

2024-03-08 Thread via GitHub
nastra commented on code in PR #9839: URL: https://github.com/apache/iceberg/pull/9839#discussion_r1517381648 ## core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java: ## @@ -1444,7 +1484,7 @@ public void testCatalogTokenRefresh(String oauth2ServerUri) {

Re: [PR] Feature make oauth `audience` configurable [iceberg]

2024-03-08 Thread via GitHub
nastra commented on code in PR #9839: URL: https://github.com/apache/iceberg/pull/9839#discussion_r1517389925 ## core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java: ## @@ -471,7 +515,13 @@ static void setTokenRefreshNumRetries(int retries) { */ public sta

Re: [PR] Core: Add test for renaming table to a non-existing namespace [iceberg]

2024-03-08 Thread via GitHub
nastra commented on PR #9895: URL: https://github.com/apache/iceberg/pull/9895#issuecomment-1985258825 thanks everyone for reviewing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Core: Add test for renaming table to a non-existing namespace [iceberg]

2024-03-08 Thread via GitHub
nastra merged PR #9895: URL: https://github.com/apache/iceberg/pull/9895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Feature make oauth `audience` configurable [iceberg]

2024-03-08 Thread via GitHub
nastra commented on code in PR #9839: URL: https://github.com/apache/iceberg/pull/9839#discussion_r1517380056 ## core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java: ## @@ -394,20 +430,24 @@ public static class AuthSession { private volatile boolean keepRefreshe

Re: [PR] Feature make oauth `audience` configurable [iceberg]

2024-03-08 Thread via GitHub
himadripal commented on code in PR #9839: URL: https://github.com/apache/iceberg/pull/9839#discussion_r1517402474 ## core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java: ## @@ -471,7 +515,13 @@ static void setTokenRefreshNumRetries(int retries) { */ public

Re: [PR] Feature make oauth `audience` configurable [iceberg]

2024-03-08 Thread via GitHub
himadripal commented on code in PR #9839: URL: https://github.com/apache/iceberg/pull/9839#discussion_r1517402474 ## core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java: ## @@ -471,7 +515,13 @@ static void setTokenRefreshNumRetries(int retries) { */ public

Re: [PR] Feature make oauth `audience` configurable [iceberg]

2024-03-08 Thread via GitHub
himadripal commented on code in PR #9839: URL: https://github.com/apache/iceberg/pull/9839#discussion_r1517402474 ## core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java: ## @@ -471,7 +515,13 @@ static void setTokenRefreshNumRetries(int retries) { */ public

Re: [PR] Feature make oauth `audience` configurable [iceberg]

2024-03-08 Thread via GitHub
nastra commented on PR #9839: URL: https://github.com/apache/iceberg/pull/9839#issuecomment-1985279889 overall I think adding these optional OAuth2 params make sense to me. I'll also link to the [OAuth2 spec](https://datatracker.ietf.org/doc/html/rfc8693#name-token-exchange-request-and-) f

Re: [PR] Feature make oauth `audience` configurable [iceberg]

2024-03-08 Thread via GitHub
himadripal commented on code in PR #9839: URL: https://github.com/apache/iceberg/pull/9839#discussion_r1517414956 ## core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java: ## @@ -257,8 +292,9 @@ private static Map tokenExchangeRequest( formData.put(ACTOR_TOKEN,

Re: [I] [feature request] easier API to set table properties [iceberg-python]

2024-03-08 Thread via GitHub
HonahX commented on issue #502: URL: https://github.com/apache/iceberg-python/issues/502#issuecomment-1985304133 Thanks @syun64 @kevinjqliu for the thoughts and explanation. Since users seem to benefit from dictionaries and kwargs, I think it is good idea to support both (as in #503 ) --

Re: [PR] Set table properties with dictionary [iceberg-python]

2024-03-08 Thread via GitHub
HonahX merged PR #503: URL: https://github.com/apache/iceberg-python/pull/503 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [I] [feature request] easier API to set table properties [iceberg-python]

2024-03-08 Thread via GitHub
HonahX closed issue #502: [feature request] easier API to set table properties URL: https://github.com/apache/iceberg-python/issues/502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Imports decouple [iceberg-python]

2024-03-08 Thread via GitHub
HonahX merged PR #505: URL: https://github.com/apache/iceberg-python/pull/505 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [I] About /v1/config REST API endpoint [iceberg]

2024-03-08 Thread via GitHub
ajantha-bhat commented on issue #9880: URL: https://github.com/apache/iceberg/issues/9880#issuecomment-1985360044 Thanks. But may be we should use a separate PATCH/PUT instead of sending in a GET request as we want to update the resource here. -- This is an automated message from

Re: [PR] Build: Free disk space before running action in Spark CI [iceberg]

2024-03-08 Thread via GitHub
nastra commented on PR #9786: URL: https://github.com/apache/iceberg/pull/9786#issuecomment-1985450508 Seems to be still an issue in the latest runs: https://github.com/apache/iceberg/actions/runs/8200693411/job/22427953001 -- This is an automated message from the Apache Git Service. To r

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

2024-03-08 Thread via GitHub
tomtongue commented on PR #9892: URL: https://github.com/apache/iceberg/pull/9892#issuecomment-1985474689 @nastra Update the snapshot files. Could you review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Core: Handle listing tables/views in empty namespaces [iceberg]

2024-03-08 Thread via GitHub
nastra commented on code in PR #9890: URL: https://github.com/apache/iceberg/pull/9890#discussion_r1517567287 ## core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java: ## @@ -168,6 +168,14 @@ protected boolean supportsNamesWithDot() { return true; } + protec

Re: [PR] Core: Handle listing tables/views in empty namespaces [iceberg]

2024-03-08 Thread via GitHub
nastra commented on code in PR #9890: URL: https://github.com/apache/iceberg/pull/9890#discussion_r1517571160 ## core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java: ## @@ -987,6 +995,61 @@ public void testListTables() { assertEmpty("Should not contain ns_2.tabl

Re: [PR] Core: Handle listing tables/views in empty namespaces [iceberg]

2024-03-08 Thread via GitHub
nastra commented on code in PR #9890: URL: https://github.com/apache/iceberg/pull/9890#discussion_r1517613054 ## core/src/main/java/org/apache/iceberg/inmemory/InMemoryCatalog.java: ## @@ -395,7 +395,9 @@ public void doCommit(TableMetadata base, TableMetadata metadata) {

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

2024-03-08 Thread via GitHub
nastra commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1517614107 ## core/src/test/java/org/apache/iceberg/LocalTableOperations.java: ## @@ -63,7 +65,9 @@ public String metadataFileLocation(String fileName) { fileName,

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

2024-03-08 Thread via GitHub
nastra commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1517614411 ## core/src/test/java/org/apache/iceberg/TestSnapshotJson.java: ## @@ -19,23 +19,24 @@ package org.apache.iceberg; import static org.apache.iceberg.Files.localInput;

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

2024-03-08 Thread via GitHub
nastra commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1517614955 ## core/src/test/java/org/apache/iceberg/TestSnapshotJson.java: ## @@ -19,23 +19,24 @@ package org.apache.iceberg; import static org.apache.iceberg.Files.localInput;

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

2024-03-08 Thread via GitHub
nastra commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1517615186 ## core/src/test/java/org/apache/iceberg/TestSnapshotJson.java: ## @@ -19,23 +19,24 @@ package org.apache.iceberg; import static org.apache.iceberg.Files.localInput;

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

2024-03-08 Thread via GitHub
nastra commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1517616912 ## core/src/test/java/org/apache/iceberg/TestSnapshotJson.java: ## @@ -149,29 +182,34 @@ public void testJsonConversionWithV1Manifests() { timestampMillis);

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

2024-03-08 Thread via GitHub
nastra commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1517617834 ## core/src/test/java/org/apache/iceberg/TestSnapshotJson.java: ## @@ -49,12 +50,23 @@ public void testJsonConversion() throws IOException { String json = SnapshotP

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

2024-03-08 Thread via GitHub
nastra commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1517620107 ## core/src/test/java/org/apache/iceberg/TestTableMetadata.java: ## @@ -87,7 +86,7 @@ public class TestTableMetadata { .desc(Expressions.bucket("z", 4), NullO

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

2024-03-08 Thread via GitHub
nastra commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1517620401 ## core/src/test/java/org/apache/iceberg/TestTableMetadata.java: ## @@ -1731,7 +1730,7 @@ public void testNoTrailingLocationSlash() { private String createManifestL

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

2024-03-08 Thread via GitHub
nastra commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1517621786 ## core/src/test/java/org/apache/iceberg/TestSnapshotManager.java: ## @@ -177,120 +177,115 @@ public void testCherryPickFromBranch() { long lastSnapshotId = table.c

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

2024-03-08 Thread via GitHub
nastra commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1517622216 ## core/src/test/java/org/apache/iceberg/TestSnapshotManager.java: ## @@ -177,120 +177,115 @@ public void testCherryPickFromBranch() { long lastSnapshotId = table.c

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

2024-03-08 Thread via GitHub
nastra commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1517622548 ## core/src/test/java/org/apache/iceberg/TestSnapshotManager.java: ## @@ -301,32 +296,31 @@ public void testCreateBranchFailsWhenRefAlreadyExists() { .hasMessag

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

2024-03-08 Thread via GitHub
nastra commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1517624708 ## core/src/test/java/org/apache/iceberg/TestSnapshotManager.java: ## @@ -700,81 +689,82 @@ public void testAttemptToRollbackToCurrentSnapshot() { table.manageSnaps

Re: [PR] Core: Handle listing tables/views in empty namespaces [iceberg]

2024-03-08 Thread via GitHub
nastra commented on code in PR #9890: URL: https://github.com/apache/iceberg/pull/9890#discussion_r1517627456 ## core/src/main/java/org/apache/iceberg/inmemory/InMemoryCatalog.java: ## @@ -288,6 +288,7 @@ public List listNamespaces(Namespace namespace) throws NoSuchNamespac

Re: [I] Library public api isolation and import decoupling [iceberg-python]

2024-03-08 Thread via GitHub
ndrluis commented on issue #499: URL: https://github.com/apache/iceberg-python/issues/499#issuecomment-1985722458 @kevinjqliu Agreed, I haven't found anything that addresses this issue or provides a warning when it occurs. It seems like something the community has accepted, but I believe it

Re: [PR] Build: Bump com.palantir.baseline:gradle-baseline-java from 4.42.0 to 5.43.0 [iceberg]

2024-03-08 Thread via GitHub
nastra closed pull request #9858: Build: Bump com.palantir.baseline:gradle-baseline-java from 4.42.0 to 5.43.0 URL: https://github.com/apache/iceberg/pull/9858 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Build: Bump com.palantir.baseline:gradle-baseline-java from 4.42.0 to 5.43.0 [iceberg]

2024-03-08 Thread via GitHub
dependabot[bot] commented on PR #9858: URL: https://github.com/apache/iceberg/pull/9858#issuecomment-1985726060 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

Re: [PR] Build: Bump spring-boot from 2.5.4 to 3.2.3 [iceberg]

2024-03-08 Thread via GitHub
nastra closed pull request #9796: Build: Bump spring-boot from 2.5.4 to 3.2.3 URL: https://github.com/apache/iceberg/pull/9796 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] Build: Bump spring-boot from 2.5.4 to 3.2.3 [iceberg]

2024-03-08 Thread via GitHub
dependabot[bot] commented on PR #9796: URL: https://github.com/apache/iceberg/pull/9796#issuecomment-1985729696 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by

Re: [PR] Build: Bump com.google.cloud:libraries-bom from 26.28.0 to 26.33.0 [iceberg]

2024-03-08 Thread via GitHub
nastra closed pull request #9794: Build: Bump com.google.cloud:libraries-bom from 26.28.0 to 26.33.0 URL: https://github.com/apache/iceberg/pull/9794 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Build: Bump com.google.cloud:libraries-bom from 26.28.0 to 26.33.0 [iceberg]

2024-03-08 Thread via GitHub
dependabot[bot] commented on PR #9794: URL: https://github.com/apache/iceberg/pull/9794#issuecomment-1985744377 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

Re: [PR] Build: Bump net.snowflake:snowflake-jdbc from 3.14.5 to 3.15.0 [iceberg]

2024-03-08 Thread via GitHub
nastra closed pull request #9797: Build: Bump net.snowflake:snowflake-jdbc from 3.14.5 to 3.15.0 URL: https://github.com/apache/iceberg/pull/9797 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Build: Bump net.snowflake:snowflake-jdbc from 3.14.5 to 3.15.0 [iceberg]

2024-03-08 Thread via GitHub
dependabot[bot] commented on PR #9797: URL: https://github.com/apache/iceberg/pull/9797#issuecomment-1985745044 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

Re: [PR] Build: Bump org.springframework:spring-web from 5.3.30 to 6.1.4 [iceberg]

2024-03-08 Thread via GitHub
nastra closed pull request #9748: Build: Bump org.springframework:spring-web from 5.3.30 to 6.1.4 URL: https://github.com/apache/iceberg/pull/9748 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Build: Bump org.springframework:spring-web from 5.3.30 to 6.1.4 [iceberg]

2024-03-08 Thread via GitHub
dependabot[bot] commented on PR #9748: URL: https://github.com/apache/iceberg/pull/9748#issuecomment-1985745769 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

Re: [PR] Build: Bump com.google.errorprone:error_prone_annotations from 2.24.1 to 2.25.0 [iceberg]

2024-03-08 Thread via GitHub
nastra closed pull request #9746: Build: Bump com.google.errorprone:error_prone_annotations from 2.24.1 to 2.25.0 URL: https://github.com/apache/iceberg/pull/9746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] Build: Bump com.google.errorprone:error_prone_annotations from 2.24.1 to 2.25.0 [iceberg]

2024-03-08 Thread via GitHub
dependabot[bot] commented on PR #9746: URL: https://github.com/apache/iceberg/pull/9746#issuecomment-1985746185 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

Re: [PR] Build: Bump org.openapitools:openapi-generator-gradle-plugin from 6.6.0 to 7.3.0 [iceberg]

2024-03-08 Thread via GitHub
nastra closed pull request #9703: Build: Bump org.openapitools:openapi-generator-gradle-plugin from 6.6.0 to 7.3.0 URL: https://github.com/apache/iceberg/pull/9703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] Build: Bump org.openapitools:openapi-generator-gradle-plugin from 6.6.0 to 7.3.0 [iceberg]

2024-03-08 Thread via GitHub
dependabot[bot] commented on PR #9703: URL: https://github.com/apache/iceberg/pull/9703#issuecomment-1985747945 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

Re: [PR] HIVE-28021: escape percent symbol [iceberg]

2024-03-08 Thread via GitHub
nastra commented on code in PR #9667: URL: https://github.com/apache/iceberg/pull/9667#discussion_r1517758155 ## mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerNoScan.java: ## @@ -966,4 +966,41 @@ private String getCurrentSnapshotForHiveCatalogTable(or

Re: [I] Add hive metastore catalog support [iceberg-rust]

2024-03-08 Thread via GitHub
marvinlanhenke commented on issue #113: URL: https://github.com/apache/iceberg-rust/issues/113#issuecomment-1985760454 @Xuanwo @liurenjie1024 ...just a quick update and a request for feedback. I 'finished' the work on all the namespace operations. Since this would be my first co

Re: [PR] Build: Bump com.diffplug.spotless:spotless-plugin-gradle from 6.13.0 to 6.25.0 [iceberg]

2024-03-08 Thread via GitHub
dependabot[bot] commented on PR #9569: URL: https://github.com/apache/iceberg/pull/9569#issuecomment-1985765560 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

Re: [PR] Build: Bump com.diffplug.spotless:spotless-plugin-gradle from 6.13.0 to 6.25.0 [iceberg]

2024-03-08 Thread via GitHub
nastra closed pull request #9569: Build: Bump com.diffplug.spotless:spotless-plugin-gradle from 6.13.0 to 6.25.0 URL: https://github.com/apache/iceberg/pull/9569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

2024-03-08 Thread via GitHub
tomtongue commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1517821079 ## core/src/test/java/org/apache/iceberg/LocalTableOperations.java: ## @@ -63,7 +65,9 @@ public String metadataFileLocation(String fileName) { fileName,

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

2024-03-08 Thread via GitHub
tomtongue commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1517827090 ## core/src/test/java/org/apache/iceberg/TestSnapshotJson.java: ## @@ -19,23 +19,24 @@ package org.apache.iceberg; import static org.apache.iceberg.Files.localInp

[I] Parquet bloom filter doesn't work with nested fields [iceberg]

2024-03-08 Thread via GitHub
hussein-awala opened a new issue, #9898: URL: https://github.com/apache/iceberg/issues/9898 ### Apache Iceberg version 1.4.3 (latest release) ### Query engine Spark ### Please describe the bug 🐞 I have an Iceberg table, and I want to create two bloom filters

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

2024-03-08 Thread via GitHub
tomtongue commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1517838222 ## core/src/test/java/org/apache/iceberg/TestTableMetadata.java: ## @@ -1731,7 +1730,7 @@ public void testNoTrailingLocationSlash() { private String createManife

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

2024-03-08 Thread via GitHub
tomtongue commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1517839588 ## core/src/test/java/org/apache/iceberg/TestSnapshotManager.java: ## @@ -177,120 +177,115 @@ public void testCherryPickFromBranch() { long lastSnapshotId = tabl

Re: [PR] Flink: implement range partitioner for map data statistics [iceberg]

2024-03-08 Thread via GitHub
stevenzwu commented on code in PR #9321: URL: https://github.com/apache/iceberg/pull/9321#discussion_r1517846647 ## flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/sink/shuffle/MapRangePartitioner.java: ## @@ -0,0 +1,378 @@ +/* + * Licensed to the Apache Software Founda

Re: [I] Add hive metastore catalog support [iceberg-rust]

2024-03-08 Thread via GitHub
Xuanwo commented on issue #113: URL: https://github.com/apache/iceberg-rust/issues/113#issuecomment-1985888081 > I 'finished' the work on all the namespace operations. Awesome! > I just want to make sure it aligns with the rest of the codebase, before I put in the effort to imp

Re: [I] Rename `stat_table` in `Catalog` trait [iceberg-rust]

2024-03-08 Thread via GitHub
Xuanwo commented on issue #236: URL: https://github.com/apache/iceberg-rust/issues/236#issuecomment-1985889243 I remember that `stat_table` will also return some metadata of this table. cc @Fokko @liurenjie1024, any comments? -- This is an automated message from the Apache Git Servi

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

2024-03-08 Thread via GitHub
tomtongue commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1517865244 ## core/src/test/java/org/apache/iceberg/TestSnapshotJson.java: ## @@ -49,12 +50,23 @@ public void testJsonConversion() throws IOException { String json = Snapsh

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

2024-03-08 Thread via GitHub
tomtongue commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1517865244 ## core/src/test/java/org/apache/iceberg/TestSnapshotJson.java: ## @@ -49,12 +50,23 @@ public void testJsonConversion() throws IOException { String json = Snapsh

Re: [I] Library public api isolation and import decoupling [iceberg-python]

2024-03-08 Thread via GitHub
ndrluis commented on issue #499: URL: https://github.com/apache/iceberg-python/issues/499#issuecomment-1985907062 Issue to follow up https://github.com/astral-sh/ruff/issues/10300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

2024-03-08 Thread via GitHub
tomtongue commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1517877405 ## core/src/test/java/org/apache/iceberg/TestSnapshotManager.java: ## @@ -700,81 +689,82 @@ public void testAttemptToRollbackToCurrentSnapshot() { table.manageSn

Re: [I] Rename `stat_table` in `Catalog` trait [iceberg-rust]

2024-03-08 Thread via GitHub
marvinlanhenke commented on issue #236: URL: https://github.com/apache/iceberg-rust/issues/236#issuecomment-1985944355 > I remember that `stat_table` will also return some metadata of this table. I only took a look at the java & python hive implementation and I couldn't find a similia

[PR] Core: add missing `@Test` annotation in TestRESTCatalog [iceberg]

2024-03-08 Thread via GitHub
adutra opened a new pull request, #9899: URL: https://github.com/apache/iceberg/pull/9899 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[PR] Add hive metastore catalog support (part 1/2) [iceberg-rust]

2024-03-08 Thread via GitHub
marvinlanhenke opened a new pull request, #237: URL: https://github.com/apache/iceberg-rust/pull/237 ### Which issue does this PR close? Closes #113 partly. ### Rationale for this change Add hive metastore support, to reach feature parity with other iceberg implementations.

Re: [I] Add hive metastore catalog support [iceberg-rust]

2024-03-08 Thread via GitHub
marvinlanhenke commented on issue #113: URL: https://github.com/apache/iceberg-rust/issues/113#issuecomment-1985986494 > In short, submit a PR and then we can polish it together. Sounds good to me - looking forward to it. Best regards. -- This is an automated message from the

Re: [PR] Allow setting non-string typed values in `set_properties` [iceberg-python]

2024-03-08 Thread via GitHub
kevinjqliu commented on PR #504: URL: https://github.com/apache/iceberg-python/pull/504#issuecomment-1985996781 rebased after #503 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-03-08 Thread via GitHub
rahil-c commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1518068800 ## open-api/rest-catalog-open-api.yaml: ## @@ -2068,6 +2162,145 @@ components: items: $ref: '#/components/schemas/PartitionStatisticsFile' +

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-03-08 Thread via GitHub
rahil-c commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1518068800 ## open-api/rest-catalog-open-api.yaml: ## @@ -2068,6 +2162,145 @@ components: items: $ref: '#/components/schemas/PartitionStatisticsFile' +

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-03-08 Thread via GitHub
rahil-c commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1518075237 ## open-api/rest-catalog-open-api.yaml: ## @@ -2068,6 +2162,145 @@ components: items: $ref: '#/components/schemas/PartitionStatisticsFile' +

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-03-08 Thread via GitHub
rahil-c commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1518075237 ## open-api/rest-catalog-open-api.yaml: ## @@ -2068,6 +2162,145 @@ components: items: $ref: '#/components/schemas/PartitionStatisticsFile' +

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-03-08 Thread via GitHub
rahil-c commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1518068800 ## open-api/rest-catalog-open-api.yaml: ## @@ -2068,6 +2162,145 @@ components: items: $ref: '#/components/schemas/PartitionStatisticsFile' +

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-03-08 Thread via GitHub
rahil-c commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1518113629 ## open-api/rest-catalog-open-api.yaml: ## @@ -537,6 +537,108 @@ paths: 5XX: $ref: '#/components/responses/ServerErrorResponse' + /v1/{prefix}/na

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-03-08 Thread via GitHub
rahil-c commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1518118829 ## open-api/rest-catalog-open-api.yaml: ## @@ -3789,6 +4097,21 @@ components: EmptyResponse: $ref: '#/components/examples/ListNamespacesEmpt

Re: [I] Getting java.lang.NoSuchMethodError org.apache.iceberg.util.JsonUtil.mapper() With Hive catalog [iceberg]

2024-03-08 Thread via GitHub
ismailsimsek commented on issue #9848: URL: https://github.com/apache/iceberg/issues/9848#issuecomment-1986226824 Fixed https://github.com/memiiso/debezium-server-iceberg/issues/271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [I] Getting java.lang.NoSuchMethodError org.apache.iceberg.util.JsonUtil.mapper() With Hive catalog [iceberg]

2024-03-08 Thread via GitHub
ismailsimsek closed issue #9848: Getting java.lang.NoSuchMethodError org.apache.iceberg.util.JsonUtil.mapper() With Hive catalog URL: https://github.com/apache/iceberg/issues/9848 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] Feature make oauth `audience` configurable [iceberg]

2024-03-08 Thread via GitHub
flyrain commented on code in PR #9839: URL: https://github.com/apache/iceberg/pull/9839#discussion_r1518181685 ## core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java: ## @@ -471,7 +515,13 @@ static void setTokenRefreshNumRetries(int retries) { */ public st

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-03-08 Thread via GitHub
rahil-c commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1518181730 ## open-api/rest-catalog-open-api.yaml: ## @@ -3789,6 +4097,21 @@ components: EmptyResponse: $ref: '#/components/examples/ListNamespacesEmpt

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-03-08 Thread via GitHub
rahil-c commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1518182591 ## open-api/rest-catalog-open-api.yaml: ## @@ -537,6 +537,108 @@ paths: 5XX: $ref: '#/components/responses/ServerErrorResponse' + /v1/{prefix}/na

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-03-08 Thread via GitHub
rahil-c commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1518183297 ## open-api/rest-catalog-open-api.yaml: ## @@ -537,6 +537,108 @@ paths: 5XX: $ref: '#/components/responses/ServerErrorResponse' + /v1/{prefix}/na

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-03-08 Thread via GitHub
rahil-c commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1518184139 ## open-api/rest-catalog-open-api.yaml: ## @@ -537,6 +537,108 @@ paths: 5XX: $ref: '#/components/responses/ServerErrorResponse' + /v1/{prefix}/na

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-03-08 Thread via GitHub
rahil-c commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1518068800 ## open-api/rest-catalog-open-api.yaml: ## @@ -2068,6 +2162,145 @@ components: items: $ref: '#/components/schemas/PartitionStatisticsFile' +

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-03-08 Thread via GitHub
rahil-c commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1517180435 ## open-api/rest-catalog-open-api.yaml: ## @@ -2838,6 +3093,59 @@ components: additionalProperties: type: string +PreplanTableRequest: +

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-03-08 Thread via GitHub
rahil-c commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1517180435 ## open-api/rest-catalog-open-api.yaml: ## @@ -2838,6 +3093,59 @@ components: additionalProperties: type: string +PreplanTableRequest: +

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-03-08 Thread via GitHub
jackye1995 commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1518328719 ## open-api/rest-catalog-open-api.yaml: ## @@ -2106,6 +2204,41 @@ components: items: $ref: '#/components/schemas/PartitionStatisticsFile' +

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-03-08 Thread via GitHub
jackye1995 commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1518329140 ## open-api/rest-catalog-open-api.yaml: ## @@ -2068,6 +2162,145 @@ components: items: $ref: '#/components/schemas/PartitionStatisticsFile'

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-03-08 Thread via GitHub
jackye1995 commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1518330379 ## open-api/rest-catalog-open-api.yaml: ## @@ -2106,6 +2204,41 @@ components: items: $ref: '#/components/schemas/PartitionStatisticsFile' +

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-03-08 Thread via GitHub
jackye1995 commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1518331988 ## open-api/rest-catalog-open-api.yaml: ## @@ -3789,6 +3995,21 @@ components: EmptyResponse: $ref: '#/components/examples/ListNamespacesE

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-03-08 Thread via GitHub
jackye1995 commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1518332560 ## open-api/rest-catalog-open-api.yaml: ## @@ -3804,6 +4025,21 @@ components: } } +UnprocessableEntityResponse: + description: +

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-03-08 Thread via GitHub
jackye1995 commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1518375778 ## open-api/rest-catalog-open-api.yaml: ## @@ -2838,6 +3093,59 @@ components: additionalProperties: type: string +PreplanTableRequest:

[PR] Minor: Parse rowGroupSize as a long [iceberg]

2024-03-08 Thread via GitHub
hussein-awala opened a new pull request, #9900: URL: https://github.com/apache/iceberg/pull/9900 `withRowGroupSize(int rowGroupSize)` is deprecated in `ParquetWriter` and currently, the max possible rowGroupSize in Iceberg is 2GB (max Java int) which will be fixed after this PR. -- This

Re: [PR] Spark 3.4, 3.3 : support output-spec-id in rewrite (back port #9803) [iceberg]

2024-03-08 Thread via GitHub
himadripal commented on PR #9901: URL: https://github.com/apache/iceberg/pull/9901#issuecomment-1986580223 @RussellSpitzer @aokolnychyi @flyrain @szehon-ho -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] Spark 3.4, 3.3 : support output-spec-id in rewrite (back port #9803) [iceberg]

2024-03-08 Thread via GitHub
himadripal opened a new pull request, #9901: URL: https://github.com/apache/iceberg/pull/9901 Backport #9803 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

2024-03-08 Thread via GitHub
tomtongue commented on PR #9892: URL: https://github.com/apache/iceberg/pull/9892#issuecomment-1986579621 @nastra Thanks for the review. Reflected your comments. Could you review the new one? -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [I] Flink 1.11.1 Not Supoort timestamptz [iceberg]

2024-03-08 Thread via GitHub
github-actions[bot] commented on issue #1915: URL: https://github.com/apache/iceberg/issues/1915#issuecomment-1986587888 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] Spark Table With Timestamp Cannot Query By Flink [iceberg]

2024-03-08 Thread via GitHub
github-actions[bot] commented on issue #1916: URL: https://github.com/apache/iceberg/issues/1916#issuecomment-1986587898 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

  1   2   >