nastra commented on code in PR #9892:
URL: https://github.com/apache/iceberg/pull/9892#discussion_r1517622548
##########
core/src/test/java/org/apache/iceberg/TestSnapshotManager.java:
##########
@@ -301,32 +296,31 @@ public void testCreateBranchFailsWhenRefAlreadyExists() {
.hasMessage("Ref branch2 already exists");
}
- @Test
+ @TestTemplate
public void testCreateTag() {
table.newAppend().appendFile(FILE_A).commit();
long snapshotId = table.currentSnapshot().snapshotId();
// Test a basic case of creating a tag
table.manageSnapshots().createTag("tag1", snapshotId).commit();
SnapshotRef expectedTag = table.ops().refresh().ref("tag1");
- Assert.assertTrue(
- expectedTag != null &&
expectedTag.equals(SnapshotRef.tagBuilder(snapshotId).build()));
+ assertThat(expectedTag).isNotNull();
+
assertThat(expectedTag).isEqualTo(SnapshotRef.tagBuilder(snapshotId).build());
Review Comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
