nastra commented on code in PR #9839:
URL: https://github.com/apache/iceberg/pull/9839#discussion_r1517389925
##########
core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java:
##########
@@ -471,7 +515,13 @@ static void setTokenRefreshNumRetries(int retries) {
*/
public static AuthSession empty() {
return new AuthSession(
- ImmutableMap.of(), null, null, null, OAuth2Properties.CATALOG_SCOPE,
null);
+ ImmutableMap.of(),
+ null,
+ null,
+ null,
+ OAuth2Properties.CATALOG_SCOPE,
+ null,
+ ImmutableMap.of());
Review Comment:
it has become quite painful to add new functionality/parameters to
`AuthSession`, since it requires adding a single param at a bunch of places.
The most recent change was done by #8976.
A while ago I experimented with an
[`AuthConfig`](https://github.com/apache/iceberg/commit/3bed59907f4230d10a97742c58ab4b85ce7b1ebf#diff-d783470ff004c360395125d467f1aadd776c8c9e925ba52639a405a03a72b870R647),
which would carry all parameters required for an `AuthSession`, so that it
would be easier to add new configuration parameters to it. So I wonder if we
should refactor `AuthSession` and its configuration so that it's less painful
to add new stuff to it?
/cc @danielcweeks @amogh-jahagirdar @rdblue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
