nastra commented on code in PR #9839:
URL: https://github.com/apache/iceberg/pull/9839#discussion_r1517380056
##########
core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java:
##########
@@ -394,20 +430,24 @@ public static class AuthSession {
private volatile boolean keepRefreshed = true;
private final String oauth2ServerUri;
+ private volatile Map<String, String> optionalOAuthParams =
ImmutableMap.of();
Review Comment:
why does this have to be `volatile`? The others are `volatile` because they
are being updated when the session token is refreshed but I don't think this
appleis for that map
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
