flyrain commented on code in PR #9839:
URL: https://github.com/apache/iceberg/pull/9839#discussion_r1518181685
##########
core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java:
##########
@@ -471,7 +515,13 @@ static void setTokenRefreshNumRetries(int retries) {
*/
public static AuthSession empty() {
return new AuthSession(
- ImmutableMap.of(), null, null, null, OAuth2Properties.CATALOG_SCOPE,
null);
+ ImmutableMap.of(),
+ null,
+ null,
+ null,
+ OAuth2Properties.CATALOG_SCOPE,
+ null,
+ ImmutableMap.of());
Review Comment:
Can we generate the request class(e.g.,
[OAuthClientCredentialsRequest](https://github.com/apache/iceberg/blob/bcbcbb263ea7e13ab22d0feb918e207c7e42dbbd/open-api/rest-catalog-open-api.yaml#L2919)
) from the spec so that we can pass a request object with all required and
optional params? By doing that, we will always make sure the impl. synced with
spec.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
