jackye1995 commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1518375778
########## open-api/rest-catalog-open-api.yaml: ########## @@ -2838,6 +3093,59 @@ components: additionalProperties: type: string + PreplanTableRequest: + type: object + required: + - select + - filter + - case-sensitive + properties: + select: + description: A list of the selected column names + type: array + items: + type: string + filter: + $ref: '#/components/schemas/Expression' + case-sensitive: + description: Indicates whether column selection and filtering should be case sensitive + type: boolean + snapshot-id: + description: an int64 snapshot ID (if snapshot-range is not present); optional and defaults to the table's current snapshot + type: integer + format: int64 + snapshot-range: + description: a JSON list containing exactly 2 int64 snapshot IDs (if snapshot-id is not present) representing the start (exclusive) and end (inclusive) snapshots Review Comment: btw just to clarify my comment, I definitely agree exclusive start and inclusive end is the most common use case in incremental pipelines. I just think it might confuse user because the common "range" in programming language has been inclusive start exclusive end, and not everyone would read the description carefully. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org