himadripal commented on code in PR #9839: URL: https://github.com/apache/iceberg/pull/9839#discussion_r1517414956
########## core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java: ########## @@ -257,8 +292,9 @@ private static Map<String, String> tokenExchangeRequest( formData.put(ACTOR_TOKEN, actorToken); formData.put(ACTOR_TOKEN_TYPE, actorTokenType); } + formData.putAll(optionalParams); - return formData.build(); + return formData.buildKeepingLast(); Review Comment: please note, changed it to `buildKeepingLast()` , I noticed everywhere else `build` is used which throws exception if it encounters duplicate keys. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org