nastra commented on code in PR #9667: URL: https://github.com/apache/iceberg/pull/9667#discussion_r1517758155
########## mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerNoScan.java: ########## @@ -966,4 +966,41 @@ private String getCurrentSnapshotForHiveCatalogTable(org.apache.iceberg.Table ic return ((BaseMetastoreTableOperations) ((BaseTable) icebergTable).operations()) .currentMetadataLocation(); } + + @Test + public void testCreateTableWithPercentInName() throws IOException { + Assume.assumeTrue("This test requires Hive Version 4.", HiveVersion.min(HiveVersion.HIVE_4)); Review Comment: is this test even applicable then for the Iceberg codebase? Iceberg + Hive4 are maintained by the Hive community in https://github.com/apache/hive/tree/master/iceberg -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org