huaxingao commented on PR #11799:
URL: https://github.com/apache/iceberg/pull/11799#issuecomment-2583265677
Thanks a lot! @RussellSpitzer @singhpk234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
RussellSpitzer merged PR #11799:
URL: https://github.com/apache/iceberg/pull/11799
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
RussellSpitzer commented on PR #11799:
URL: https://github.com/apache/iceberg/pull/11799#issuecomment-2582949679
Thanks @huaxingao for the PR and @singhpk234 For the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
huaxingao commented on PR #11799:
URL: https://github.com/apache/iceberg/pull/11799#issuecomment-2581580455
I looked the code again, for the newly added method
```
private void setBloomFilterConfig(
Context context,
MessageType parquetSchema,
BiCons
huaxingao commented on PR #11799:
URL: https://github.com/apache/iceberg/pull/11799#issuecomment-2573977829
@RussellSpitzer
> Looks like tests are not passing?
I looked at the failed test again. The reason it failed is that the bloom
filter is set on a field of the struct typ
huaxingao commented on PR #11799:
URL: https://github.com/apache/iceberg/pull/11799#issuecomment-2569656539
> Looks like tests are not passing?
Somehow the test failed 😟
The test passed on my local machine. I stepped into the test, and it worked
as expected. I'm not sure why the te
RussellSpitzer commented on PR #11799:
URL: https://github.com/apache/iceberg/pull/11799#issuecomment-2569564361
Looks like tests are not passing?
```java
TestBloomRowGroupFilter > testStructFieldEq() FAILED
org.opentest4j.AssertionFailedError: [Should not read: value outside
RussellSpitzer commented on code in PR #11799:
URL: https://github.com/apache/iceberg/pull/11799#discussion_r1901996701
##
parquet/src/test/java/org/apache/iceberg/parquet/TestBloomRowGroupFilter.java:
##
@@ -193,6 +195,7 @@ public void createInputFile() throws IOException {
huaxingao commented on code in PR #11799:
URL: https://github.com/apache/iceberg/pull/11799#discussion_r1901407198
##
parquet/src/test/java/org/apache/iceberg/parquet/TestBloomRowGroupFilter.java:
##
@@ -109,7 +109,7 @@ public class TestBloomRowGroupFilter {
optional(
RussellSpitzer commented on code in PR #11799:
URL: https://github.com/apache/iceberg/pull/11799#discussion_r1901261131
##
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##
@@ -266,6 +272,47 @@ private WriteBuilder createContextFunc(
return this;
}
RussellSpitzer commented on code in PR #11799:
URL: https://github.com/apache/iceberg/pull/11799#discussion_r1901260644
##
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##
@@ -266,6 +272,47 @@ private WriteBuilder createContextFunc(
return this;
}
RussellSpitzer commented on code in PR #11799:
URL: https://github.com/apache/iceberg/pull/11799#discussion_r1901255023
##
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##
@@ -266,6 +272,47 @@ private WriteBuilder createContextFunc(
return this;
}
RussellSpitzer commented on code in PR #11799:
URL: https://github.com/apache/iceberg/pull/11799#discussion_r1901247617
##
parquet/src/test/java/org/apache/iceberg/parquet/TestBloomRowGroupFilter.java:
##
@@ -683,23 +684,23 @@ public void testBytesEq() {
}
@Test
- publi
huaxingao commented on code in PR #11799:
URL: https://github.com/apache/iceberg/pull/11799#discussion_r1893254315
##
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##
@@ -266,6 +272,43 @@ private WriteBuilder createContextFunc(
return this;
}
+
huaxingao commented on code in PR #11799:
URL: https://github.com/apache/iceberg/pull/11799#discussion_r1893254124
##
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##
@@ -266,6 +272,43 @@ private WriteBuilder createContextFunc(
return this;
}
+
singhpk234 commented on code in PR #11799:
URL: https://github.com/apache/iceberg/pull/11799#discussion_r1893197627
##
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##
@@ -266,6 +272,43 @@ private WriteBuilder createContextFunc(
return this;
}
+
huaxingao commented on code in PR #11799:
URL: https://github.com/apache/iceberg/pull/11799#discussion_r1887787105
##
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##
@@ -266,6 +272,43 @@ private WriteBuilder createContextFunc(
return this;
}
+
singhpk234 commented on code in PR #11799:
URL: https://github.com/apache/iceberg/pull/11799#discussion_r1887780848
##
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##
@@ -266,6 +272,43 @@ private WriteBuilder createContextFunc(
return this;
}
+
huaxingao commented on PR #11799:
URL: https://github.com/apache/iceberg/pull/11799#issuecomment-2547289098
cc @szehon-ho
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
19 matches
Mail list logo
