singhpk234 commented on code in PR #11799:
URL: https://github.com/apache/iceberg/pull/11799#discussion_r1887780848
##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -266,6 +272,43 @@ private WriteBuilder createContextFunc(
return this;
}
+ private <T> void setBloomFilterConfig(
+ Context context,
+ MessageType parquetSchema,
+ BiConsumer<String, Boolean> withBloomFilterEnabled,
+ BiConsumer<String, Double> withBloomFilterFPP) {
+
+ Map<Integer, String> fieldIdToParquetPath =
+ parquetSchema.getColumns().stream()
+ .collect(
+ Collectors.toMap(
+ col -> col.getPrimitiveType().getId().intValue(),
+ col -> String.join(".", col.getPath())));
+
+ context
+ .columnBloomFilterEnabled()
+ .forEach(
+ (colPath, isEnabled) -> {
+ Types.NestedField fieldId =
schema.caseInsensitiveFindField(colPath);
Review Comment:
[doubt] does sensitivity matters ? can this :
```
write.parquet.bloom-filter-enabled.column.CoL1
```
be applied to parquet files with schema containing `col1` ?
if not should we explicitly do lowercase post deriving the configs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
