RussellSpitzer commented on code in PR #11799:
URL: https://github.com/apache/iceberg/pull/11799#discussion_r1901260644
##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -266,6 +272,47 @@ private WriteBuilder createContextFunc(
return this;
}
+ private <T> void setBloomFilterConfig(
+ Context context,
+ MessageType parquetSchema,
+ BiConsumer<String, Boolean> withBloomFilterEnabled,
+ BiConsumer<String, Double> withBloomFilterFPP) {
Review Comment:
For example couldn't we keep the old layout of the code and just use
https://github.com/apache/iceberg/blob/afda8be25652d44d9339a79c6797b6bf20c55bd6/core/src/main/java/org/apache/iceberg/avro/AvroSchemaUtil.java#L483
```java
for (Map.Entry<String, String> entry :
columnBloomFilterEnabled.entrySet()) {
String colPath = makeCompatibleName(entry.getKey());
String bloomEnabled = entry.getValue();
parquetWriteBuilder.withBloomFilterEnabled(colPath,
Boolean.parseBoolean(bloomEnabled));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
