huaxingao commented on PR #11799:
URL: https://github.com/apache/iceberg/pull/11799#issuecomment-2573977829
@RussellSpitzer
> Looks like tests are not passing?
I looked at the failed test again. The reason it failed is that the bloom
filter is set on a field of the struct type `struct_not_null._int_field`. When
we use:
```
String colPath = makeCompatibleName(entry.getKey());
```
`makeCompatibleName` changes `struct_not_null._int_field` to`
struct_not_null_x2E_int_field`, which we actually don't want. If the entry
contains a period, we could check if it is a field of a complex type and only
apply `makeCompatibleName` to the field name. However, I feel it's probably
simpler to use my original approach: get the fieldId of the entry, and then get
the corresponding Parquet path for that fieldId.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
