RussellSpitzer commented on code in PR #11799:
URL: https://github.com/apache/iceberg/pull/11799#discussion_r1901996701
##########
parquet/src/test/java/org/apache/iceberg/parquet/TestBloomRowGroupFilter.java:
##########
@@ -193,6 +195,7 @@ public void createInputFile() throws IOException {
// build struct field schema
org.apache.avro.Schema structSchema =
AvroSchemaUtil.convert(UNDERSCORE_STRUCT_FIELD_TYPE);
+ String compatibleFieldName =
AvroSchemaUtil.makeCompatibleName("_incompatible-name");
Review Comment:
This is a personal nit of mine, but I don't like when the tests use the same
implementation as the prod code to get expected values. Could we just hard wire
in the converted name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
