huaxingao commented on code in PR #11799:
URL: https://github.com/apache/iceberg/pull/11799#discussion_r1901407198
##########
parquet/src/test/java/org/apache/iceberg/parquet/TestBloomRowGroupFilter.java:
##########
@@ -109,7 +109,7 @@ public class TestBloomRowGroupFilter {
optional(22, "timestamp", Types.TimestampType.withoutZone()),
optional(23, "timestamptz", Types.TimestampType.withZone()),
optional(24, "binary", Types.BinaryType.get()),
- optional(25, "int_decimal", Types.DecimalType.of(8, 2)),
+ optional(25, "int-decimal", Types.DecimalType.of(8, 2)),
Review Comment:
Changed. Thanks
##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -266,6 +272,47 @@ private WriteBuilder createContextFunc(
return this;
}
+ private <T> void setBloomFilterConfig(
+ Context context,
+ MessageType parquetSchema,
+ BiConsumer<String, Boolean> withBloomFilterEnabled,
+ BiConsumer<String, Double> withBloomFilterFPP) {
Review Comment:
It's simpler to use `makeCompatibleName`. I have made the changes. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
