RussellSpitzer commented on code in PR #11799:
URL: https://github.com/apache/iceberg/pull/11799#discussion_r1901247617
##########
parquet/src/test/java/org/apache/iceberg/parquet/TestBloomRowGroupFilter.java:
##########
@@ -683,23 +684,23 @@ public void testBytesEq() {
}
@Test
- public void testIntDeciamlEq() {
+ public void testIntDecimalEq() {
for (int i = 0; i < INT_VALUE_COUNT; i++) {
boolean shouldRead =
new ParquetBloomRowGroupFilter(
- SCHEMA, equal("int_decimal", new
BigDecimal(String.valueOf(77.77 + i))))
+ SCHEMA, equal("int-decimal", new
BigDecimal(String.valueOf(77.77 + i))))
.shouldRead(parquetSchema, rowGroupMetadata, bloomStore);
assertThat(shouldRead).as("Should read: decimal within range").isTrue();
}
boolean shouldRead =
- new ParquetBloomRowGroupFilter(SCHEMA, equal("int_decimal", new
BigDecimal("1234.56")))
+ new ParquetBloomRowGroupFilter(SCHEMA, equal("int-decimal", new
BigDecimal("1234.56")))
.shouldRead(parquetSchema, rowGroupMetadata, bloomStore);
assertThat(shouldRead).as("Should not read: decimal outside
range").isFalse();
}
@Test
- public void testLongDeciamlEq() {
+ public void testLongDecimalEq() {
Review Comment:
Let's keep this fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
