huaxingao commented on PR #11799:
URL: https://github.com/apache/iceberg/pull/11799#issuecomment-2581580455
I looked the code again, for the newly added method
```
private <T> void setBloomFilterConfig(
Context context,
MessageType parquetSchema,
BiConsumer<String, Boolean> withBloomFilterEnabled,
BiConsumer<String, Double> withBloomFilterFPP)
```
The reason I want to pass by function is that the callers are different
functions.
One caller is
```
setBloomFilterConfig(
context, type, propsBuilder::withBloomFilterEnabled,
propsBuilder::withBloomFilterFPP);
```
`propsBuilder` is a ParquetProperties and it calls
https://github.com/apache/parquet-java/blob/master/parquet-column/src/main/java/org/apache/parquet/column/ParquetProperties.java#L637
Another caller is
```
setBloomFilterConfig(
context,
type,
parquetWriteBuilder::withBloomFilterEnabled,
parquetWriteBuilder::withBloomFilterFPP);
```
`parquetWriteBuilder` is a ParquetWriter and it calls
https://github.com/apache/parquet-java/blob/master/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetWriter.java#L810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
