huaxingao commented on code in PR #11799:
URL: https://github.com/apache/iceberg/pull/11799#discussion_r1893254315
##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -266,6 +272,43 @@ private WriteBuilder createContextFunc(
return this;
}
+ private <T> void setBloomFilterConfig(
+ Context context,
+ MessageType parquetSchema,
+ BiConsumer<String, Boolean> withBloomFilterEnabled,
+ BiConsumer<String, Double> withBloomFilterFPP) {
+
+ Map<Integer, String> fieldIdToParquetPath =
+ parquetSchema.getColumns().stream()
+ .collect(
+ Collectors.toMap(
+ col -> col.getPrimitiveType().getId().intValue(),
+ col -> String.join(".", col.getPath())));
+
+ context
+ .columnBloomFilterEnabled()
+ .forEach(
+ (colPath, isEnabled) -> {
Review Comment:
If isEnable is true, iceberg will call [withBloomFilterEnabled(String
columnPath, boolean
enabled)](https://github.com/apache/parquet-java/blob/master/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetWriter.java#L810).
If isEnable is false, we don't need to do anything.
##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -266,6 +272,43 @@ private WriteBuilder createContextFunc(
return this;
}
+ private <T> void setBloomFilterConfig(
+ Context context,
+ MessageType parquetSchema,
+ BiConsumer<String, Boolean> withBloomFilterEnabled,
+ BiConsumer<String, Double> withBloomFilterFPP) {
+
+ Map<Integer, String> fieldIdToParquetPath =
+ parquetSchema.getColumns().stream()
+ .collect(
+ Collectors.toMap(
+ col -> col.getPrimitiveType().getId().intValue(),
+ col -> String.join(".", col.getPath())));
+
+ context
+ .columnBloomFilterEnabled()
+ .forEach(
+ (colPath, isEnabled) -> {
+ Types.NestedField fieldId = schema.findField(colPath);
Review Comment:
Updated. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
