Re: [PR] Migrate Files, Append and Overwrite files in Core to JUnit5 [iceberg]

nastra merged PR #9994: URL: https://github.com/apache/iceberg/pull/9994 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Migrate Files, Append and Overwrite files in Core to JUnit5 [iceberg]

tomtongue commented on code in PR #9994: URL: https://github.com/apache/iceberg/pull/9994#discussion_r1532128519 ## core/src/test/java/org/apache/iceberg/TestFastAppend.java: ## @@ -360,32 +341,20 @@ public void testAppendManifestWithSnapshotIdInheritance() throws IOException {

Re: [PR] Migrate Files, Append and Overwrite files in Core to JUnit5 [iceberg]

nastra commented on code in PR #9994: URL: https://github.com/apache/iceberg/pull/9994#discussion_r1532123199 ## core/src/test/java/org/apache/iceberg/TestFastAppend.java: ## @@ -360,32 +341,20 @@ public void testAppendManifestWithSnapshotIdInheritance() throws IOException {

Re: [PR] Migrate Files, Append and Overwrite files in Core to JUnit5 [iceberg]

tomtongue commented on code in PR #9994: URL: https://github.com/apache/iceberg/pull/9994#discussion_r1531982526 ## core/src/test/java/org/apache/iceberg/TestMergeAppend.java: ## @@ -92,28 +83,28 @@ public void testEmptyTableAppend() { statuses(Status.ADDED, Status.ADDE

Re: [PR] Migrate Files, Append and Overwrite files in Core to JUnit5 [iceberg]

tomtongue commented on code in PR #9994: URL: https://github.com/apache/iceberg/pull/9994#discussion_r1531986609 ## core/src/test/java/org/apache/iceberg/TestMergeAppend.java: ## @@ -147,25 +135,22 @@ public void testEmptyTableAppendFilesAndManifest() throws IOException {

Re: [PR] Migrate Files, Append and Overwrite files in Core to JUnit5 [iceberg]

tomtongue commented on code in PR #9994: URL: https://github.com/apache/iceberg/pull/9994#discussion_r1531979921 ## core/src/test/java/org/apache/iceberg/TestRewriteFiles.java: ## @@ -323,14 +304,13 @@ public void testRewriteDataAndDeleteFiles() { statuses(DELETED, EXIS

Re: [PR] Migrate Files, Append and Overwrite files in Core to JUnit5 [iceberg]

tomtongue commented on code in PR #9994: URL: https://github.com/apache/iceberg/pull/9994#discussion_r1531972009 ## core/src/test/java/org/apache/iceberg/TestMergeAppend.java: ## @@ -1375,47 +1294,45 @@ public void testManifestEntryFieldIdsForChangedPartitionSpecForV1Table() {

Re: [PR] Migrate Files, Append and Overwrite files in Core to JUnit5 [iceberg]

tomtongue commented on code in PR #9994: URL: https://github.com/apache/iceberg/pull/9994#discussion_r1531957297 ## core/src/test/java/org/apache/iceberg/TestMergeAppend.java: ## @@ -92,28 +83,28 @@ public void testEmptyTableAppend() { statuses(Status.ADDED, Status.ADDE

Re: [PR] Migrate Files, Append and Overwrite files in Core to JUnit5 [iceberg]

tomtongue commented on code in PR #9994: URL: https://github.com/apache/iceberg/pull/9994#discussion_r1531963997 ## core/src/test/java/org/apache/iceberg/TestMergeAppend.java: ## @@ -92,28 +83,28 @@ public void testEmptyTableAppend() { statuses(Status.ADDED, Status.ADDE

Re: [PR] Migrate Files, Append and Overwrite files in Core to JUnit5 [iceberg]

tomtongue commented on code in PR #9994: URL: https://github.com/apache/iceberg/pull/9994#discussion_r1531957297 ## core/src/test/java/org/apache/iceberg/TestMergeAppend.java: ## @@ -92,28 +83,28 @@ public void testEmptyTableAppend() { statuses(Status.ADDED, Status.ADDE

Re: [PR] Migrate Files, Append and Overwrite files in Core to JUnit5 [iceberg]

tomtongue commented on code in PR #9994: URL: https://github.com/apache/iceberg/pull/9994#discussion_r1531936851 ## core/src/test/java/org/apache/iceberg/TestFastAppend.java: ## @@ -489,32 +457,29 @@ public void testIncludedPartitionSummaries() { table.currentSnapshot()

Re: [PR] Migrate Files, Append and Overwrite files in Core to JUnit5 [iceberg]

nastra commented on code in PR #9994: URL: https://github.com/apache/iceberg/pull/9994#discussion_r1531695247 ## core/src/test/java/org/apache/iceberg/TestMergeAppend.java: ## @@ -1425,32 +1342,29 @@ public void testIncludedPartitionSummaries() { table.currentSnapshot()

Re: [PR] Migrate Files, Append and Overwrite files in Core to JUnit5 [iceberg]

nastra commented on code in PR #9994: URL: https://github.com/apache/iceberg/pull/9994#discussion_r1531694926 ## core/src/test/java/org/apache/iceberg/TestMergeAppend.java: ## @@ -1375,47 +1294,45 @@ public void testManifestEntryFieldIdsForChangedPartitionSpecForV1Table() {

Re: [PR] Migrate Files, Append and Overwrite files in Core to JUnit5 [iceberg]

nastra commented on code in PR #9994: URL: https://github.com/apache/iceberg/pull/9994#discussion_r1531694296 ## core/src/test/java/org/apache/iceberg/TestMergeAppend.java: ## @@ -1135,33 +1071,21 @@ public void testAppendManifestWithSnapshotIdInheritance() throws IOException {

Re: [PR] Migrate Files, Append and Overwrite files in Core to JUnit5 [iceberg]

nastra commented on code in PR #9994: URL: https://github.com/apache/iceberg/pull/9994#discussion_r1531693411 ## core/src/test/java/org/apache/iceberg/TestMergeAppend.java: ## @@ -418,15 +392,12 @@ public void testManifestMergeMinCount() throws IOException { statuses(S

Re: [PR] Migrate Files, Append and Overwrite files in Core to JUnit5 [iceberg]

nastra commented on code in PR #9994: URL: https://github.com/apache/iceberg/pull/9994#discussion_r1531690739 ## core/src/test/java/org/apache/iceberg/TestMergeAppend.java: ## @@ -92,28 +83,28 @@ public void testEmptyTableAppend() { statuses(Status.ADDED, Status.ADDED))

Re: [PR] Migrate Files, Append and Overwrite files in Core to JUnit5 [iceberg]

nastra commented on code in PR #9994: URL: https://github.com/apache/iceberg/pull/9994#discussion_r1531691801 ## core/src/test/java/org/apache/iceberg/TestMergeAppend.java: ## @@ -147,25 +135,22 @@ public void testEmptyTableAppendFilesAndManifest() throws IOException {

Re: [PR] Migrate Files, Append and Overwrite files in Core to JUnit5 [iceberg]

nastra commented on code in PR #9994: URL: https://github.com/apache/iceberg/pull/9994#discussion_r1531691051 ## core/src/test/java/org/apache/iceberg/TestMergeAppend.java: ## @@ -126,19 +117,16 @@ public void testEmptyTableAppendManifest() throws IOException { statuse

Re: [PR] Migrate Files, Append and Overwrite files in Core to JUnit5 [iceberg]

nastra commented on code in PR #9994: URL: https://github.com/apache/iceberg/pull/9994#discussion_r1531690739 ## core/src/test/java/org/apache/iceberg/TestMergeAppend.java: ## @@ -92,28 +83,28 @@ public void testEmptyTableAppend() { statuses(Status.ADDED, Status.ADDED))

Re: [PR] Migrate Files, Append and Overwrite files in Core to JUnit5 [iceberg]

nastra commented on code in PR #9994: URL: https://github.com/apache/iceberg/pull/9994#discussion_r1531689228 ## core/src/test/java/org/apache/iceberg/TestRewriteFiles.java: ## @@ -649,25 +614,22 @@ public void testReplaceEqualityDeletesWithPositionDeletes() { commit(tab

Re: [PR] Migrate Files, Append and Overwrite files in Core to JUnit5 [iceberg]

nastra commented on code in PR #9994: URL: https://github.com/apache/iceberg/pull/9994#discussion_r1531688931 ## core/src/test/java/org/apache/iceberg/TestRewriteFiles.java: ## @@ -590,25 +558,22 @@ public void testRecoverWhenRewriteBothDataAndDeleteFiles() { commit(tabl

Re: [PR] Migrate Files, Append and Overwrite files in Core to JUnit5 [iceberg]

nastra commented on code in PR #9994: URL: https://github.com/apache/iceberg/pull/9994#discussion_r1531686995 ## core/src/test/java/org/apache/iceberg/TestRewriteFiles.java: ## @@ -524,23 +496,19 @@ public void testRecovery() { commit(table, rewrite, branch); -Asser

Re: [PR] Migrate Files, Append and Overwrite files in Core to JUnit5 [iceberg]

nastra commented on code in PR #9994: URL: https://github.com/apache/iceberg/pull/9994#discussion_r1531686477 ## core/src/test/java/org/apache/iceberg/TestRewriteFiles.java: ## @@ -420,28 +393,27 @@ public void testFailure() { table.newRewrite().rewriteFiles(Sets.newSet

Re: [PR] Migrate Files, Append and Overwrite files in Core to JUnit5 [iceberg]

nastra commented on code in PR #9994: URL: https://github.com/apache/iceberg/pull/9994#discussion_r1531685943 ## core/src/test/java/org/apache/iceberg/TestRewriteFiles.java: ## @@ -373,24 +352,18 @@ public void testRewriteDataAndAssignOldSequenceNumber() { .rewr

Re: [PR] Migrate Files, Append and Overwrite files in Core to JUnit5 [iceberg]

nastra commented on code in PR #9994: URL: https://github.com/apache/iceberg/pull/9994#discussion_r1531676106 ## core/src/test/java/org/apache/iceberg/TestRewriteFiles.java: ## @@ -323,14 +304,13 @@ public void testRewriteDataAndDeleteFiles() { statuses(DELETED, EXISTIN

Re: [PR] Migrate Files, Append and Overwrite files in Core to JUnit5 [iceberg]

nastra commented on code in PR #9994: URL: https://github.com/apache/iceberg/pull/9994#discussion_r1531675499 ## core/src/test/java/org/apache/iceberg/TestRewriteFiles.java: ## @@ -246,14 +231,13 @@ public void testAddAndDelete() { statuses(DELETED, EXISTING)); /

Re: [PR] Migrate Files, Append and Overwrite files in Core to JUnit5 [iceberg]

nastra commented on code in PR #9994: URL: https://github.com/apache/iceberg/pull/9994#discussion_r1531670793 ## core/src/test/java/org/apache/iceberg/TestFastAppend.java: ## @@ -524,69 +489,63 @@ public void testIncludedPartitionSummaryLimit() { table.currentSnapshot()

Re: [PR] Migrate Files, Append and Overwrite files in Core to JUnit5 [iceberg]

nastra commented on code in PR #9994: URL: https://github.com/apache/iceberg/pull/9994#discussion_r1531669820 ## core/src/test/java/org/apache/iceberg/TestFastAppend.java: ## @@ -489,32 +457,29 @@ public void testIncludedPartitionSummaries() { table.currentSnapshot().su

Re: [PR] Migrate Files, Append and Overwrite files in Core to JUnit5 [iceberg]

nastra commented on code in PR #9994: URL: https://github.com/apache/iceberg/pull/9994#discussion_r1531667791 ## core/src/test/java/org/apache/iceberg/TestFastAppend.java: ## @@ -360,32 +342,20 @@ public void testAppendManifestWithSnapshotIdInheritance() throws IOException {

Re: [PR] Migrate Files, Append and Overwrite files in Core to JUnit5 [iceberg]

nastra commented on code in PR #9994: URL: https://github.com/apache/iceberg/pull/9994#discussion_r1531663316 ## core/src/test/java/org/apache/iceberg/TestFastAppend.java: ## @@ -86,16 +82,13 @@ public void testEmptyTableAppendManifest() throws IOException { ManifestFile

Re: [PR] Migrate Files, Append and Overwrite files in Core to JUnit5 [iceberg]

tomtongue commented on PR #9994: URL: https://github.com/apache/iceberg/pull/9994#issuecomment-2005245722 @nastra Change the classes in Core to JUnit5. Could you review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub