tomtongue commented on code in PR #9994:
URL: https://github.com/apache/iceberg/pull/9994#discussion_r1531979921
##########
core/src/test/java/org/apache/iceberg/TestRewriteFiles.java:
##########
@@ -323,14 +304,13 @@ public void testRewriteDataAndDeleteFiles() {
statuses(DELETED, EXISTING));
// We should only get the 5 manifests that this test is expected to add.
- Assert.assertEquals("Only 5 manifests should exist", 5,
listManifestFiles().size());
+ assertThat(listManifestFiles()).hasSize(5);
}
- @Test
+ @TestTemplate
public void testRewriteDataAndAssignOldSequenceNumber() {
- Assume.assumeTrue(
- "Sequence number is only supported in iceberg format v2. ",
formatVersion > 1);
- Assert.assertEquals("Table should start empty", 0,
listManifestFiles().size());
+ assumeThat(formatVersion).isGreaterThan(1);
Review Comment:
Okay sure, add the description here.
##########
core/src/test/java/org/apache/iceberg/TestRewriteFiles.java:
##########
@@ -323,14 +304,13 @@ public void testRewriteDataAndDeleteFiles() {
statuses(DELETED, EXISTING));
// We should only get the 5 manifests that this test is expected to add.
- Assert.assertEquals("Only 5 manifests should exist", 5,
listManifestFiles().size());
+ assertThat(listManifestFiles()).hasSize(5);
}
- @Test
+ @TestTemplate
public void testRewriteDataAndAssignOldSequenceNumber() {
- Assume.assumeTrue(
- "Sequence number is only supported in iceberg format v2. ",
formatVersion > 1);
- Assert.assertEquals("Table should start empty", 0,
listManifestFiles().size());
+ assumeThat(formatVersion).isGreaterThan(1);
Review Comment:
Okay sure, add the description here and other places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
