nastra commented on code in PR #9994:
URL: https://github.com/apache/iceberg/pull/9994#discussion_r1531669820
##########
core/src/test/java/org/apache/iceberg/TestFastAppend.java:
##########
@@ -489,32 +457,29 @@ public void testIncludedPartitionSummaries() {
table.currentSnapshot().summary().keySet().stream()
.filter(key ->
key.startsWith(SnapshotSummary.CHANGED_PARTITION_PREFIX))
.collect(Collectors.toSet());
- Assert.assertEquals("Should include a partition summary", 1,
partitionSummaryKeys.size());
+ assertThat(partitionSummaryKeys).hasSize(1);
String summariesIncluded =
table
.currentSnapshot()
.summary()
.getOrDefault(SnapshotSummary.PARTITION_SUMMARY_PROP, "false");
- Assert.assertEquals(
- "Should set partition-summaries-included to true", "true",
summariesIncluded);
+ assertThat(summariesIncluded).isEqualTo("true");
String changedPartitions =
table.currentSnapshot().summary().get(SnapshotSummary.CHANGED_PARTITION_COUNT_PROP);
- Assert.assertEquals("Should set changed partition count", "1",
changedPartitions);
+ assertThat(changedPartitions).isEqualTo("1");
String partitionSummary =
table
.currentSnapshot()
.summary()
.get(SnapshotSummary.CHANGED_PARTITION_PREFIX + "data_bucket=0");
- Assert.assertEquals(
- "Summary should include 1 file with 1 record that is 10 bytes",
- "added-data-files=1,added-records=1,added-files-size=10",
- partitionSummary);
+ assertThat(partitionSummary)
Review Comment:
please also use containsEntry here. I don't think we need to define the
`partitionSummary` variable a few lines above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
