nastra commented on code in PR #9994:
URL: https://github.com/apache/iceberg/pull/9994#discussion_r1531686995
##########
core/src/test/java/org/apache/iceberg/TestRewriteFiles.java:
##########
@@ -524,23 +496,19 @@ public void testRecovery() {
commit(table, rewrite, branch);
- Assert.assertTrue("Should reuse the manifest for appends", new
File(manifest1.path()).exists());
- Assert.assertTrue(
- "Should reuse the manifest with deletes", new
File(manifest2.path()).exists());
+ assertThat(new File(manifest1.path())).exists();
+ assertThat(new File(manifest2.path())).exists();
TableMetadata metadata = readMetadata();
- Assert.assertTrue(
- "Should commit the manifest for append",
- latestSnapshot(metadata,
branch).allManifests(table.io()).contains(manifest2));
+ assertThat(latestSnapshot(metadata,
branch).allManifests(table.io())).contains(manifest2);
// 2 manifests added by rewrite and 1 original manifest should be found.
- Assert.assertEquals("Only 3 manifests should exist", 3,
listManifestFiles().size());
+ assertThat(listManifestFiles()).hasSize(3);
}
- @Test
+ @TestTemplate
public void testRecoverWhenRewriteBothDataAndDeleteFiles() {
- Assume.assumeTrue(
- "Rewriting delete files is only supported in iceberg format v2. ",
formatVersion > 1);
+ assumeThat(formatVersion).isGreaterThan(1);
Review Comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
