nastra commented on code in PR #9994:
URL: https://github.com/apache/iceberg/pull/9994#discussion_r1531663316
##########
core/src/test/java/org/apache/iceberg/TestFastAppend.java:
##########
@@ -86,16 +82,13 @@ public void testEmptyTableAppendManifest() throws
IOException {
ManifestFile committedManifest =
Iterables.getOnlyElement(snap.allManifests(FILE_IO));
if (formatVersion == 1) {
-
Assertions.assertThat(committedManifest.path()).isNotEqualTo(manifest.path());
+ assertThat(manifest.path()).isNotEqualTo(committedManifest.path());
} else {
-
Assertions.assertThat(committedManifest.path()).isEqualTo(manifest.path());
+ assertThat(manifest.path()).isEqualTo(committedManifest.path());
}
// validate that the metadata summary is correct when using appendManifest
- Assert.assertEquals(
- "Summary metadata should include 2 added files",
- "2",
- snap.summary().get("added-data-files"));
+ assertThat(snap.summary().get("added-data-files")).isEqualTo("2");
Review Comment:
containsEntry should be used here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
