nastra commented on code in PR #9994:
URL: https://github.com/apache/iceberg/pull/9994#discussion_r1531690739
##########
core/src/test/java/org/apache/iceberg/TestMergeAppend.java:
##########
@@ -92,28 +83,28 @@ public void testEmptyTableAppend() {
statuses(Status.ADDED, Status.ADDED));
}
- @Test
+ @TestTemplate
public void testEmptyTableAppendManifest() throws IOException {
- Assert.assertEquals("Table should start empty", 0,
listManifestFiles().size());
+ assertThat(listManifestFiles()).isEmpty();
TableMetadata base = readMetadata();
- Assert.assertNull("Should not have a current snapshot",
base.currentSnapshot());
- Assert.assertEquals("Last sequence number should be 0", 0,
base.lastSequenceNumber());
+ assertThat(base.currentSnapshot()).isNull();
+ assertThat(base.lastSequenceNumber()).isEqualTo(0);
ManifestFile manifest = writeManifest(FILE_A, FILE_B);
Snapshot committedSnapshot = commit(table,
table.newAppend().appendManifest(manifest), branch);
- Assert.assertNotNull("Should create a snapshot", committedSnapshot);
+ assertThat(committedSnapshot).isNotNull();
V1Assert.assertEquals(
"Last sequence number should be 0", 0,
table.ops().current().lastSequenceNumber());
V2Assert.assertEquals(
"Last sequence number should be 1", 1,
table.ops().current().lastSequenceNumber());
List<ManifestFile> manifests = committedSnapshot.allManifests(table.io());
ManifestFile committedManifest = Iterables.getOnlyElement(manifests);
if (formatVersion == 1) {
-
Assertions.assertThat(committedManifest.path()).isNotEqualTo(manifest.path());
+ assertThat(committedManifest.path()).isNotEqualTo(manifest.path());
Review Comment:
in one of the other classes in this PR you switched the actual/expected
parts. So I think in that other test class turning actual/expected should
probably be reverted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
