nastra commented on code in PR #9994:
URL: https://github.com/apache/iceberg/pull/9994#discussion_r1531689228
##########
core/src/test/java/org/apache/iceberg/TestRewriteFiles.java:
##########
@@ -649,25 +614,22 @@ public void
testReplaceEqualityDeletesWithPositionDeletes() {
commit(table, rewrite, branch);
- Assert.assertTrue("Should reuse new manifest", new
File(manifest1.path()).exists());
- Assert.assertTrue("Should reuse new manifest", new
File(manifest2.path()).exists());
- Assert.assertTrue("Should reuse new manifest", new
File(manifest3.path()).exists());
+ assertThat(new File(manifest1.path())).exists();
+ assertThat(new File(manifest2.path())).exists();
+ assertThat(new File(manifest3.path())).exists();
metadata = readMetadata();
List<ManifestFile> committedManifests = Lists.newArrayList(manifest1,
manifest2, manifest3);
- Assert.assertEquals(
- "Should committed the manifests",
- latestSnapshot(metadata, branch).allManifests(table.io()),
- committedManifests);
+ assertThat(latestSnapshot(metadata, branch).allManifests(table.io()))
+ .isEqualTo(committedManifests);
// As commit success all the manifests added with rewrite should be
available.
- Assert.assertEquals("4 manifests should exist", 4,
listManifestFiles().size());
+ assertThat(listManifestFiles()).hasSize(4);
}
- @Test
+ @TestTemplate
public void testRemoveAllDeletes() {
- Assume.assumeTrue(
- "Rewriting delete files is only supported in iceberg format v2. ",
formatVersion > 1);
+ assumeThat(formatVersion).isGreaterThan(1);
Review Comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
