nastra commented on code in PR #9994:
URL: https://github.com/apache/iceberg/pull/9994#discussion_r1531691801
##########
core/src/test/java/org/apache/iceberg/TestMergeAppend.java:
##########
@@ -147,25 +135,22 @@ public void testEmptyTableAppendFilesAndManifest() throws
IOException {
table.newAppend().appendFile(FILE_C).appendFile(FILE_D).appendManifest(manifest),
branch);
- Assert.assertNotNull("Should create a snapshot", committedSnapshot);
+ assertThat(committedSnapshot).isNotNull();
V1Assert.assertEquals(
"Last sequence number should be 0", 0,
table.ops().current().lastSequenceNumber());
V2Assert.assertEquals(
"Last sequence number should be 1", 1,
table.ops().current().lastSequenceNumber());
- Assert.assertEquals(
- "Should create 2 manifests for initial write",
- 2,
- committedSnapshot.allManifests(table.io()).size());
+ assertThat(committedSnapshot.allManifests(table.io())).hasSize(2);
long snapshotId = committedSnapshot.snapshotId();
ManifestFile committedManifest1 =
committedSnapshot.allManifests(table.io()).get(0);
ManifestFile committedManifest2 =
committedSnapshot.allManifests(table.io()).get(1);
if (formatVersion == 1) {
-
Assertions.assertThat(committedManifest2.path()).isNotEqualTo(manifest.path());
+ assertThat(committedManifest2.path()).isNotEqualTo(manifest.path());
Review Comment:
same as above. Which actual/expected is correct here? because in one of the
other files you changed it to be the other way around
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
