nastra commented on code in PR #9994:
URL: https://github.com/apache/iceberg/pull/9994#discussion_r1531670793
##########
core/src/test/java/org/apache/iceberg/TestFastAppend.java:
##########
@@ -524,69 +489,63 @@ public void testIncludedPartitionSummaryLimit() {
table.currentSnapshot().summary().keySet().stream()
.filter(key ->
key.startsWith(SnapshotSummary.CHANGED_PARTITION_PREFIX))
.collect(Collectors.toSet());
- Assert.assertEquals(
- "Should include no partition summaries, over limit", 0,
partitionSummaryKeys.size());
+ assertThat(partitionSummaryKeys).isEmpty();
String summariesIncluded =
table
.currentSnapshot()
.summary()
.getOrDefault(SnapshotSummary.PARTITION_SUMMARY_PROP, "false");
- Assert.assertEquals(
- "Should not set partition-summaries-included to true", "false",
summariesIncluded);
+ assertThat(summariesIncluded).isEqualTo("false");
String changedPartitions =
table.currentSnapshot().summary().get(SnapshotSummary.CHANGED_PARTITION_COUNT_PROP);
- Assert.assertEquals("Should set changed partition count", "2",
changedPartitions);
+ assertThat(changedPartitions).isEqualTo("2");
Review Comment:
containsEntry
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
