Re: [PR] API: Add Variant data type [iceberg]

rdblue commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1844731548 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -412,6 +412,41 @@ public String toString() { } } + public static class VariantType implement

Re: [PR] API: Add Variant data type [iceberg]

rdblue commented on PR #11324: URL: https://github.com/apache/iceberg/pull/11324#issuecomment-2480238364 Late +1 from me! Thanks @aihuaxu! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] API: Add Variant data type [iceberg]

RussellSpitzer merged PR #11324: URL: https://github.com/apache/iceberg/pull/11324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] API: Add Variant data type [iceberg]

RussellSpitzer commented on PR #11324: URL: https://github.com/apache/iceberg/pull/11324#issuecomment-2479712954 Sync'd up with Ryan this morning, we are good to go. Thanks @aihuaxu for working on this and @rdblue, @gene-db and @Fokko for reviews! -- This is an automated message

Re: [PR] API: Add Variant data type [iceberg]

RussellSpitzer commented on PR #11324: URL: https://github.com/apache/iceberg/pull/11324#issuecomment-2477045093 @rdblue I think you are the last reviewer on this, do you have any further comments for this one? -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] API: Add Variant data type [iceberg]

aihuaxu commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1833206108 ## api/src/main/java/org/apache/iceberg/transforms/Identity.java: ## @@ -38,6 +38,9 @@ class Identity implements Transform { */ @Deprecated public static I

Re: [PR] API: Add Variant data type [iceberg]

RussellSpitzer commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1833022565 ## api/src/main/java/org/apache/iceberg/transforms/Identity.java: ## @@ -38,6 +38,9 @@ class Identity implements Transform { */ @Deprecated public st

Re: [PR] API: Add Variant data type [iceberg]

aihuaxu commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1833199261 ## api/src/test/java/org/apache/iceberg/TestPartitionSpecValidation.java: ## @@ -312,4 +314,15 @@ public void testAddPartitionFieldsWithAndWithoutFieldIds() { a

Re: [PR] API: Add Variant data type [iceberg]

aihuaxu commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1833123566 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -412,6 +413,29 @@ public String toString() { } } + public static class VariantType extends

Re: [PR] API: Add Variant data type [iceberg]

RussellSpitzer commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1833032148 ## core/src/test/java/org/apache/iceberg/TestTableMetadata.java: ## @@ -1687,6 +1687,44 @@ public void testV3TimestampNanoTypeSupport() { 3); } +

Re: [PR] API: Add Variant data type [iceberg]

rdblue commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1832994460 ## api/src/main/java/org/apache/iceberg/transforms/Identity.java: ## @@ -38,6 +38,9 @@ class Identity implements Transform { */ @Deprecated public static Id

Re: [PR] API: Add Variant data type [iceberg]

RussellSpitzer commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1833032148 ## core/src/test/java/org/apache/iceberg/TestTableMetadata.java: ## @@ -1687,6 +1687,44 @@ public void testV3TimestampNanoTypeSupport() { 3); } +

Re: [PR] API: Add Variant data type [iceberg]

RussellSpitzer commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1833022565 ## api/src/main/java/org/apache/iceberg/transforms/Identity.java: ## @@ -38,6 +38,9 @@ class Identity implements Transform { */ @Deprecated public st

Re: [PR] API: Add Variant data type [iceberg]

rdblue commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1832990597 ## api/src/main/java/org/apache/iceberg/expressions/ExpressionUtil.java: ## @@ -562,7 +563,7 @@ private static String sanitize(Literal literal, long now, int today) {

Re: [PR] API: Add Variant data type [iceberg]

rdblue commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1833015207 ## core/src/test/java/org/apache/iceberg/TestTableMetadata.java: ## @@ -1687,6 +1687,44 @@ public void testV3TimestampNanoTypeSupport() { 3); } + @Test

Re: [PR] API: Add Variant data type [iceberg]

rdblue commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1833011700 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -412,6 +413,29 @@ public String toString() { } } + public static class VariantType extends P

Re: [PR] API: Add Variant data type [iceberg]

rdblue commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1833009142 ## api/src/test/java/org/apache/iceberg/TestPartitionSpecValidation.java: ## @@ -312,4 +314,15 @@ public void testAddPartitionFieldsWithAndWithoutFieldIds() { as

Re: [PR] API: Add Variant data type [iceberg]

rdblue commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1833006470 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -412,6 +413,29 @@ public String toString() { } } + public static class VariantType extends P

Re: [PR] API: Add Variant data type [iceberg]

aihuaxu commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1832033887 ## api/src/main/java/org/apache/iceberg/types/Type.java: ## @@ -92,6 +93,10 @@ default boolean isListType() { return false; } + default boolean isVariantTy

Re: [PR] API: Add Variant data type [iceberg]

aihuaxu commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1831845888 ## api/src/main/java/org/apache/iceberg/expressions/ExpressionUtil.java: ## @@ -562,7 +563,7 @@ private static String sanitize(Literal literal, long now, int today)

Re: [PR] API: Add Variant data type [iceberg]

aihuaxu commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1829929729 ## api/src/main/java/org/apache/iceberg/expressions/ExpressionUtil.java: ## @@ -562,7 +563,7 @@ private static String sanitize(Literal literal, long now, int today)

Re: [PR] API: Add Variant data type [iceberg]

aihuaxu commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1826493625 ## core/src/test/java/org/apache/iceberg/TestTableMetadata.java: ## @@ -1687,6 +1687,44 @@ public void testV3TimestampNanoTypeSupport() { 3); } + @Test

Re: [PR] API: Add Variant data type [iceberg]

aihuaxu commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1826477524 ## api/src/main/java/org/apache/iceberg/types/Type.java: ## @@ -92,6 +93,10 @@ default boolean isListType() { return false; } + default boolean isVariantTy

Re: [PR] API: Add Variant data type [iceberg]

aihuaxu commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1826477007 ## api/src/main/java/org/apache/iceberg/transforms/Identity.java: ## @@ -38,6 +38,8 @@ class Identity implements Transform { */ @Deprecated public static I

Re: [PR] API: Add Variant data type [iceberg]

RussellSpitzer commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1826243134 ## core/src/test/java/org/apache/iceberg/TestTableMetadata.java: ## @@ -1687,6 +1687,44 @@ public void testV3TimestampNanoTypeSupport() { 3); } +

Re: [PR] API: Add Variant data type [iceberg]

RussellSpitzer commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1826235415 ## core/src/test/java/org/apache/iceberg/TestTableMetadata.java: ## @@ -1687,6 +1687,44 @@ public void testV3TimestampNanoTypeSupport() { 3); } +

Re: [PR] API: Add Variant data type [iceberg]

RussellSpitzer commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1826240929 ## core/src/test/java/org/apache/iceberg/TestTableMetadata.java: ## @@ -1687,6 +1687,44 @@ public void testV3TimestampNanoTypeSupport() { 3); } +

Re: [PR] API: Add Variant data type [iceberg]

RussellSpitzer commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1826235415 ## core/src/test/java/org/apache/iceberg/TestTableMetadata.java: ## @@ -1687,6 +1687,44 @@ public void testV3TimestampNanoTypeSupport() { 3); } +

Re: [PR] API: Add Variant data type [iceberg]

RussellSpitzer commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1826235415 ## core/src/test/java/org/apache/iceberg/TestTableMetadata.java: ## @@ -1687,6 +1687,44 @@ public void testV3TimestampNanoTypeSupport() { 3); } +

Re: [PR] API: Add Variant data type [iceberg]

RussellSpitzer commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1826235415 ## core/src/test/java/org/apache/iceberg/TestTableMetadata.java: ## @@ -1687,6 +1687,44 @@ public void testV3TimestampNanoTypeSupport() { 3); } +

Re: [PR] API: Add Variant data type [iceberg]

RussellSpitzer commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1826235415 ## core/src/test/java/org/apache/iceberg/TestTableMetadata.java: ## @@ -1687,6 +1687,44 @@ public void testV3TimestampNanoTypeSupport() { 3); } +

Re: [PR] API: Add Variant data type [iceberg]

RussellSpitzer commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1826215525 ## api/src/main/java/org/apache/iceberg/transforms/Identity.java: ## @@ -38,6 +38,8 @@ class Identity implements Transform { */ @Deprecated public st

Re: [PR] API: Add Variant data type [iceberg]

RussellSpitzer commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1826215525 ## api/src/main/java/org/apache/iceberg/transforms/Identity.java: ## @@ -38,6 +38,8 @@ class Identity implements Transform { */ @Deprecated public st

Re: [PR] API: Add Variant data type [iceberg]

RussellSpitzer commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1826211841 ## api/src/main/java/org/apache/iceberg/types/Type.java: ## @@ -92,6 +93,10 @@ default boolean isListType() { return false; } + default boolean isVa

Re: [PR] API: Add Variant data type [iceberg]

RussellSpitzer commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1826210225 ## api/src/main/java/org/apache/iceberg/transforms/Identity.java: ## @@ -38,6 +38,8 @@ class Identity implements Transform { */ @Deprecated public st

Re: [PR] API: Add Variant data type [iceberg]

RussellSpitzer commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1826209245 ## api/src/main/java/org/apache/iceberg/transforms/Identity.java: ## @@ -38,6 +38,8 @@ class Identity implements Transform { */ @Deprecated public st

Re: [PR] API: Add Variant data type [iceberg]

RussellSpitzer commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1826206182 ## api/src/main/java/org/apache/iceberg/expressions/ExpressionUtil.java: ## @@ -562,7 +563,7 @@ private static String sanitize(Literal literal, long now, int

Re: [PR] API: Add Variant data type [iceberg]

RussellSpitzer commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1826205708 ## api/src/main/java/org/apache/iceberg/expressions/ExpressionUtil.java: ## @@ -562,7 +563,7 @@ private static String sanitize(Literal literal, long now, int

Re: [PR] API: Add Variant data type [iceberg]

aihuaxu commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1825983981 ## api/src/test/java/org/apache/iceberg/TestAccessors.java: ## @@ -247,4 +252,70 @@ public void testEmptySchema() { Schema emptySchema = new Schema(); asser

Re: [PR] API: Add Variant data type [iceberg]

aihuaxu commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1821493402 ## api/src/main/java/org/apache/iceberg/VariantLike.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribut

Re: [PR] API: Add Variant data type [iceberg]

aihuaxu commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1821493642 ## api/src/main/java/org/apache/iceberg/VariantLike.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribut

Re: [PR] API: Add Variant data type [iceberg]

aihuaxu commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1821492918 ## api/src/main/java/org/apache/iceberg/VariantLike.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribut

Re: [PR] API: Add Variant data type [iceberg]

aihuaxu commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1821277533 ## api/src/main/java/org/apache/iceberg/types/TypeUtil.java: ## @@ -534,6 +534,7 @@ private static int estimateSize(Type type) { case FIXED: return ((

Re: [PR] API: Add Variant data type [iceberg]

aihuaxu commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1817394294 ## api/src/test/java/org/apache/iceberg/TestHelpers.java: ## @@ -402,6 +406,101 @@ public int hashCode() { } } + /** A VariantLike implementation for testi

Re: [PR] API: Add Variant data type [iceberg]

rdblue commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1815802178 ## api/src/main/java/org/apache/iceberg/VariantLike.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributo

Re: [PR] API: Add Variant data type [iceberg]

rdblue commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1815789874 ## api/src/main/java/org/apache/iceberg/expressions/ExpressionUtil.java: ## @@ -562,7 +563,7 @@ private static String sanitize(Literal literal, long now, int today) {

Re: [PR] API: Add Variant data type [iceberg]

rdblue commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1815793743 ## api/src/main/java/org/apache/iceberg/types/Type.java: ## @@ -45,7 +46,8 @@ enum TypeID { DECIMAL(BigDecimal.class), STRUCT(StructLike.class), LIST(Li

Re: [PR] API: Add Variant data type [iceberg]

rdblue commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1815788236 ## api/src/main/java/org/apache/iceberg/types/TypeUtil.java: ## @@ -534,6 +534,7 @@ private static int estimateSize(Type type) { case FIXED: return ((T

Re: [PR] API: Add Variant data type [iceberg]

rdblue commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1815799646 ## api/src/main/java/org/apache/iceberg/VariantLike.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributo

Re: [PR] API: Add Variant data type [iceberg]

rdblue commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1815799200 ## api/src/main/java/org/apache/iceberg/VariantLike.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributo

Re: [PR] API: Add Variant data type [iceberg]

rdblue commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1815791799 ## api/src/test/java/org/apache/iceberg/TestHelpers.java: ## @@ -402,6 +406,101 @@ public int hashCode() { } } + /** A VariantLike implementation for testin

Re: [PR] API: Add Variant data type [iceberg]

rdblue commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1815796072 ## api/src/main/java/org/apache/iceberg/VariantLike.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributo

Re: [PR] API: Add Variant data type [iceberg]

rdblue commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1815795425 ## api/src/test/java/org/apache/iceberg/TestAccessors.java: ## @@ -247,4 +252,70 @@ public void testEmptySchema() { Schema emptySchema = new Schema(); assert

Re: [PR] API: Add Variant data type [iceberg]

rdblue commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1815795425 ## api/src/test/java/org/apache/iceberg/TestAccessors.java: ## @@ -247,4 +252,70 @@ public void testEmptySchema() { Schema emptySchema = new Schema(); assert

Re: [PR] API: Add Variant data type [iceberg]

aihuaxu commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1811485935 ## api/src/main/java/org/apache/iceberg/VariantLike.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribut

Re: [PR] API: Add Variant data type [iceberg]

aihuaxu commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1811485354 ## api/src/test/java/org/apache/iceberg/TestHelpers.java: ## @@ -402,6 +406,98 @@ public int hashCode() { } } + /** A VariantLike implementation for testin

Re: [PR] API: Add Variant data type [iceberg]

aihuaxu commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1811347080 ## api/src/main/java/org/apache/iceberg/VariantLike.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribut

Re: [PR] API: Add Variant data type [iceberg]

aihuaxu commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1811345388 ## api/src/main/java/org/apache/iceberg/VariantLike.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribut

Re: [PR] API: Add Variant data type [iceberg]

RussellSpitzer commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1811183149 ## api/src/test/java/org/apache/iceberg/TestHelpers.java: ## @@ -402,6 +406,98 @@ public int hashCode() { } } + /** A VariantLike implementation for

Re: [PR] API: Add Variant data type [iceberg]

RussellSpitzer commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1811179041 ## api/src/main/java/org/apache/iceberg/VariantLike.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more co

Re: [PR] API: Add Variant data type [iceberg]

RussellSpitzer commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r188395 ## api/src/main/java/org/apache/iceberg/VariantLike.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more co

Re: [PR] API: Add Variant data type [iceberg]

aihuaxu commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1810974129 ## api/src/main/java/org/apache/iceberg/VariantLike.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribut

Re: [PR] API: Add Variant data type [iceberg]

aihuaxu commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1810974129 ## api/src/main/java/org/apache/iceberg/VariantLike.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribut

Re: [PR] API: Add Variant data type [iceberg]

RussellSpitzer commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1809542740 ## api/src/main/java/org/apache/iceberg/VariantLike.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more co

Re: [PR] API: Add Variant data type [iceberg]

RussellSpitzer commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1809541707 ## api/src/main/java/org/apache/iceberg/VariantLike.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more co

Re: [PR] API: Add Variant data type [iceberg]

aihuaxu commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1805821651 ## api/src/main/java/org/apache/iceberg/VariantLike.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribut

Re: [PR] API: Add Variant data type [iceberg]

gene-db commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1805396309 ## api/src/main/java/org/apache/iceberg/VariantLike.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribut

Re: [PR] API: Add Variant data type [iceberg]

gene-db commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1805378000 ## api/src/main/java/org/apache/iceberg/VariantLike.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribut

Re: [PR] API: Add Variant data type [iceberg]

RussellSpitzer commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1805209323 ## api/src/main/java/org/apache/iceberg/VariantLike.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more co

Re: [PR] API: Add Variant data type [iceberg]

aihuaxu commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1805107315 ## api/src/test/java/org/apache/iceberg/types/TestSerializableTypes.java: ## @@ -112,13 +113,13 @@ public void testMaps() throws Exception { @Test public void

Re: [PR] API: Add Variant data type [iceberg]

aihuaxu commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1805107008 ## api/src/test/java/org/apache/iceberg/util/RandomUtil.java: ## @@ -225,4 +229,8 @@ private static BigInteger randomUnscaled(int precision, Random random) {

Re: [PR] API: Add Variant data type [iceberg]

aihuaxu commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1805098603 ## api/src/main/java/org/apache/iceberg/VariantLike.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribut

Re: [PR] API: Add Variant data type [iceberg]

aihuaxu commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1805063548 ## api/src/main/java/org/apache/iceberg/VariantLike.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribut

Re: [PR] API: Add Variant data type [iceberg]

RussellSpitzer commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1802058539 ## api/src/main/java/org/apache/iceberg/VariantLike.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more co

Re: [PR] API: Add Variant data type [iceberg]

RussellSpitzer commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1801763229 ## api/src/test/java/org/apache/iceberg/types/TestSerializableTypes.java: ## @@ -112,13 +113,13 @@ public void testMaps() throws Exception { @Test publ

Re: [PR] API: Add Variant data type [iceberg]

RussellSpitzer commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1801762819 ## api/src/test/java/org/apache/iceberg/util/RandomUtil.java: ## @@ -225,4 +229,8 @@ private static BigInteger randomUnscaled(int precision, Random random) {

Re: [PR] API: Add Variant data type [iceberg]

RussellSpitzer commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1801754339 ## api/src/main/java/org/apache/iceberg/VariantLike.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more co

Re: [PR] API: Add Variant data type [iceberg]

RussellSpitzer commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1801754339 ## api/src/main/java/org/apache/iceberg/VariantLike.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more co

Re: [PR] API: Add Variant data type [iceberg]

RussellSpitzer commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1801750718 ## api/src/main/java/org/apache/iceberg/VariantLike.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more co