rdblue commented on code in PR #11324: URL: https://github.com/apache/iceberg/pull/11324#discussion_r1844731548
########## api/src/main/java/org/apache/iceberg/types/Types.java: ########## @@ -412,6 +412,41 @@ public String toString() { } } + public static class VariantType implements Type { Review Comment: @aihuaxu, could you also implement the same Java serialization that we use for `PrimitiveType`? The existing `PrimitiveHolder` should work: ``` Object writeReplace() throws ObjectStreamException { return new PrimitiveHolder(toString()); } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org