rdblue commented on code in PR #11324:
URL: https://github.com/apache/iceberg/pull/11324#discussion_r1833015207


##########
core/src/test/java/org/apache/iceberg/TestTableMetadata.java:
##########
@@ -1687,6 +1687,44 @@ public void testV3TimestampNanoTypeSupport() {
         3);
   }
 
+  @Test
+  public void testV3VariantTypeSupport() {

Review Comment:
   +1 for moving this to `TestSchema`. The test here should really just be 
validating that schemas are validated against the table version, but the actual 
validation tests should be in `TestSchema`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to