aihuaxu commented on code in PR #11324:
URL: https://github.com/apache/iceberg/pull/11324#discussion_r1817394294
##########
api/src/test/java/org/apache/iceberg/TestHelpers.java:
##########
@@ -402,6 +406,101 @@ public int hashCode() {
}
}
+ /** A VariantLike implementation for testing accepting JSON input */
+ public static class JsonVariant implements VariantLike {
Review Comment:
The real implementation will be added to Iceberg-Parquet module which will
use Parquet variant encoding/decoding (see
https://github.com/aihuaxu/iceberg/pull/1/files#diff-7da5666792da1f7ea51905e40103482b66c749dda6a5c85c8a5530eda0832b54).
This test implementation in Iceberg-api is only to test out the methods in
VariantLike. Otherwise, we will introduce dependency to Parquet. Let me know if
I understand correctly on how the code is orginized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
