aihuaxu commented on code in PR #11324:
URL: https://github.com/apache/iceberg/pull/11324#discussion_r1833123566
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -412,6 +413,29 @@ public String toString() {
}
}
+ public static class VariantType extends PrimitiveType {
Review Comment:
I have `isPrimitiveType`() to return false. I was debating on that - if
VariantType extends PrimitiveType, some internal change would be easier. But
concept-wise t should be from Type directly and let me change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
