rdblue commented on code in PR #11324:
URL: https://github.com/apache/iceberg/pull/11324#discussion_r1832994460
##########
api/src/main/java/org/apache/iceberg/transforms/Identity.java:
##########
@@ -38,6 +38,9 @@ class Identity<T> implements Transform<T, T> {
*/
@Deprecated
public static <I> Identity<I> get(Type type) {
+ Preconditions.checkArgument(
+ type.typeId() != Type.TypeID.VARIANT, "Unsupported type for identity:
%s", type);
Review Comment:
I think we also need to make sure that `canTransform` doesn't accept
variants. We could special case it, but I'm actually wondering if it makes
sense for variant to be a primitive type because it is only primitive sometimes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
