aihuaxu commented on code in PR #11324:
URL: https://github.com/apache/iceberg/pull/11324#discussion_r1821277533


##########
api/src/main/java/org/apache/iceberg/types/TypeUtil.java:
##########
@@ -534,6 +534,7 @@ private static int estimateSize(Type type) {
       case FIXED:
         return ((Types.FixedType) type).length();
       case BINARY:
+      case VARIANT:

Review Comment:
   We can't have the accurate size for Variant similar to Binary. So I use the 
same value as Binary. I'm wondering how we come up with 80 for Binary.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to