rdblue commented on code in PR #11324:
URL: https://github.com/apache/iceberg/pull/11324#discussion_r1815791799
##########
api/src/test/java/org/apache/iceberg/TestHelpers.java:
##########
@@ -402,6 +406,101 @@ public int hashCode() {
}
}
+ /** A VariantLike implementation for testing accepting JSON input */
+ public static class JsonVariant implements VariantLike {
Review Comment:
Why have a test implementation of a Variant rather than just adding real
implementation? This doesn't seem valuable to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
