rdblue commented on code in PR #11324:
URL: https://github.com/apache/iceberg/pull/11324#discussion_r1833011700
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -412,6 +413,29 @@ public String toString() {
}
}
+ public static class VariantType extends PrimitiveType {
+ private static final VariantType INSTANCE = new VariantType();
+
+ public static VariantType get() {
+ return INSTANCE;
+ }
+
+ @Override
+ public boolean isPrimitiveType() {
+ return false;
Review Comment:
Ah, I see that although this extends `PrimitiveType`, it reports that it is
not one. I think it would be safer not to extend `PrimitiveType`. Good that
this is already used to get the tests passing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
