zhongqishang commented on code in PR #10526:
URL: https://github.com/apache/iceberg/pull/10526#discussion_r1683819074
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/sink/TestIcebergFilesCommitter.java:
##
@@ -204,7 +207,7 @@ public void testCommitTxn() throws Except
amogh-jahagirdar commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1683757259
##
open-api/rest-catalog-open-api.yaml:
##
@@ -3647,6 +3786,173 @@ components:
type: integer
description: "List of equality field IDs"
zhongqishang commented on code in PR #10526:
URL: https://github.com/apache/iceberg/pull/10526#discussion_r1683742893
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java:
##
@@ -426,30 +425,44 @@ private void commitOperation(
}
@Ov
amogh-jahagirdar commented on code in PR #10711:
URL: https://github.com/apache/iceberg/pull/10711#discussion_r1683681004
##
api/src/main/java/org/apache/iceberg/io/SupportsRecoveryOperations.java:
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
amogh-jahagirdar commented on code in PR #10711:
URL: https://github.com/apache/iceberg/pull/10711#discussion_r1683661895
##
api/src/main/java/org/apache/iceberg/io/SupportsRecoveryOperations.java:
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
amogh-jahagirdar commented on code in PR #10711:
URL: https://github.com/apache/iceberg/pull/10711#discussion_r1683661895
##
api/src/main/java/org/apache/iceberg/io/SupportsRecoveryOperations.java:
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
huaxingao commented on code in PR #10659:
URL: https://github.com/apache/iceberg/pull/10659#discussion_r1683659774
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkScan.java:
##
@@ -175,7 +184,37 @@ public Statistics estimateStatistics() {
protected Stat
huaxingao commented on code in PR #10659:
URL: https://github.com/apache/iceberg/pull/10659#discussion_r1683659065
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkScan.java:
##
@@ -189,9 +192,8 @@ protected Statistics estimateStatistics(Snapshot snapshot)
huaxingao commented on code in PR #10659:
URL: https://github.com/apache/iceberg/pull/10659#discussion_r1683657327
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkScan.java:
##
@@ -175,7 +184,37 @@ public Statistics estimateStatistics() {
protected Stat
huaxingao commented on code in PR #10659:
URL: https://github.com/apache/iceberg/pull/10659#discussion_r1683657244
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkSQLProperties.java:
##
@@ -90,4 +90,8 @@ private SparkSQLProperties() {}
public static final Stri
huaxingao commented on code in PR #10659:
URL: https://github.com/apache/iceberg/pull/10659#discussion_r1683657141
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkScan.java:
##
@@ -175,7 +184,37 @@ public Statistics estimateStatistics() {
protected Stat
huaxingao commented on code in PR #10659:
URL: https://github.com/apache/iceberg/pull/10659#discussion_r1683657052
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkSQLProperties.java:
##
@@ -90,4 +90,8 @@ private SparkSQLProperties() {}
public static final Stri
amogh-jahagirdar merged PR #10544:
URL: https://github.com/apache/iceberg/pull/10544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
amogh-jahagirdar commented on PR #10544:
URL: https://github.com/apache/iceberg/pull/10544#issuecomment-2237848340
Sorry for the late review on this @findepi , I was going through
https://github.com/apache/iceberg/pull/10494 and trying to understand more
about this path and saw this change
github-actions[bot] commented on issue #3044:
URL: https://github.com/apache/iceberg/issues/3044#issuecomment-2237833788
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] commented on PR #3034:
URL: https://github.com/apache/iceberg/pull/3034#issuecomment-2237833731
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
github-actions[bot] commented on PR #3029:
URL: https://github.com/apache/iceberg/pull/3029#issuecomment-2237833681
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
github-actions[bot] commented on PR #3032:
URL: https://github.com/apache/iceberg/pull/3032#issuecomment-2237833702
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
github-actions[bot] commented on PR #3013:
URL: https://github.com/apache/iceberg/pull/3013#issuecomment-2237833626
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
github-actions[bot] commented on PR #3012:
URL: https://github.com/apache/iceberg/pull/3012#issuecomment-2237833605
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
github-actions[bot] commented on issue #3003:
URL: https://github.com/apache/iceberg/issues/3003#issuecomment-2237833543
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] commented on issue #3005:
URL: https://github.com/apache/iceberg/issues/3005#issuecomment-2237833560
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] commented on issue #2993:
URL: https://github.com/apache/iceberg/issues/2993#issuecomment-2237833525
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] commented on issue #2958:
URL: https://github.com/apache/iceberg/issues/2958#issuecomment-2237833474
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] closed issue #2802: Add more description to the
Write-audit-publish feature
URL: https://github.com/apache/iceberg/issues/2802
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
github-actions[bot] commented on PR #3043:
URL: https://github.com/apache/iceberg/pull/3043#issuecomment-2237833775
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
github-actions[bot] commented on issue #3042:
URL: https://github.com/apache/iceberg/issues/3042#issuecomment-2237833753
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] commented on issue #3033:
URL: https://github.com/apache/iceberg/issues/3033#issuecomment-2237833719
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] commented on issue #3028:
URL: https://github.com/apache/iceberg/issues/3028#issuecomment-2237833661
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] commented on issue #3026:
URL: https://github.com/apache/iceberg/issues/3026#issuecomment-2237833648
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] commented on issue #3011:
URL: https://github.com/apache/iceberg/issues/3011#issuecomment-2237833593
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] commented on issue #3009:
URL: https://github.com/apache/iceberg/issues/3009#issuecomment-2237833575
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] commented on PR #2966:
URL: https://github.com/apache/iceberg/pull/2966#issuecomment-2237833493
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
github-actions[bot] commented on PR #2944:
URL: https://github.com/apache/iceberg/pull/2944#issuecomment-2237833458
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
github-actions[bot] commented on issue #2802:
URL: https://github.com/apache/iceberg/issues/2802#issuecomment-2237833306
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Gi
github-actions[bot] closed issue #2791: Alter table to generic types
URL: https://github.com/apache/iceberg/issues/2791
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
github-actions[bot] commented on issue #2791:
URL: https://github.com/apache/iceberg/issues/2791#issuecomment-2237833284
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Gi
amogh-jahagirdar commented on issue #10720:
URL: https://github.com/apache/iceberg/issues/10720#issuecomment-2237831914
@Vanlightly I was focused on the validation path, and perhaps this may be
where the formal verification model is missing.
We already set a field which will fail if
szehon-ho commented on PR #10647:
URL: https://github.com/apache/iceberg/pull/10647#issuecomment-2237794775
To confirm , you mean the code could change to not override the default
distribution mode in this scenario right? Yea I think that in line with our
original idea here.
--
This is
aokolnychyi commented on PR #10647:
URL: https://github.com/apache/iceberg/pull/10647#issuecomment-2237793353
I replied on the dev list. Let me know if you all agree, @manuzhang
@RussellSpitzer @szehon-ho.
--
This is an automated message from the Apache Git Service.
To respond to the mes
danielcweeks commented on code in PR #10711:
URL: https://github.com/apache/iceberg/pull/10711#discussion_r1683602812
##
api/src/main/java/org/apache/iceberg/io/SupportsRecoveryOperations.java:
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
danielcweeks commented on code in PR #10711:
URL: https://github.com/apache/iceberg/pull/10711#discussion_r1683601891
##
api/src/main/java/org/apache/iceberg/io/SupportsRecoveryOperations.java:
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
amogh-jahagirdar merged PR #9860:
URL: https://github.com/apache/iceberg/pull/9860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
danielcweeks commented on PR #10445:
URL: https://github.com/apache/iceberg/pull/10445#issuecomment-2237752049
Thanks for the assessment @amogh-jahagirdar. @szehon-ho, yes I think we do
want to support the work you did and add it to this action. Overall, this was
focused on fixing broken
rdblue commented on code in PR #8982:
URL: https://github.com/apache/iceberg/pull/8982#discussion_r1683583050
##
format/spec.md:
##
@@ -1370,3 +1370,16 @@ Writing v2 metadata:
* `sort_columns` was removed
Note that these requirements apply when writing data to a v2 table
stevenzwu commented on PR #10526:
URL: https://github.com/apache/iceberg/pull/10526#issuecomment-2237743264
@zhongqishang @pvary I have a uber question.
let's say checkpoint N was cancelled or timed out and checkpoint N+1
completed successfully. In this case, do we know all the writer
stevenzwu commented on code in PR #10526:
URL: https://github.com/apache/iceberg/pull/10526#discussion_r1683576927
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/sink/TestIcebergFilesCommitter.java:
##
@@ -204,7 +207,7 @@ public void testCommitTxn() throws Exception
dependabot[bot] opened a new pull request, #942:
URL: https://github.com/apache/iceberg-python/pull/942
Bumps [getdaft](https://github.com/Eventual-Inc/Daft) from 0.2.29 to 0.2.31.
Release notes
Sourced from https://github.com/Eventual-Inc/Daft/releases";>getdaft's
releases.
dependabot[bot] closed pull request #940: Bump getdaft from 0.2.29 to 0.2.30
URL: https://github.com/apache/iceberg-python/pull/940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
dependabot[bot] commented on PR #940:
URL: https://github.com/apache/iceberg-python/pull/940#issuecomment-2237724308
Superseded by #942.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
stevenzwu commented on code in PR #10526:
URL: https://github.com/apache/iceberg/pull/10526#discussion_r1683550064
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java:
##
@@ -426,30 +425,44 @@ private void commitOperation(
}
@Overr
stevenzwu commented on code in PR #10526:
URL: https://github.com/apache/iceberg/pull/10526#discussion_r1683536734
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java:
##
@@ -426,30 +425,44 @@ private void commitOperation(
}
@Overr
stevenzwu commented on code in PR #10526:
URL: https://github.com/apache/iceberg/pull/10526#discussion_r1683536734
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java:
##
@@ -426,30 +425,44 @@ private void commitOperation(
}
@Overr
stevenzwu commented on code in PR #10526:
URL: https://github.com/apache/iceberg/pull/10526#discussion_r1683518028
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java:
##
@@ -426,30 +425,44 @@ private void commitOperation(
}
@Overr
stevenzwu commented on code in PR #10526:
URL: https://github.com/apache/iceberg/pull/10526#discussion_r1683534328
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java:
##
@@ -426,30 +425,44 @@ private void commitOperation(
}
@Overr
zeroshade commented on code in PR #108:
URL: https://github.com/apache/iceberg-go/pull/108#discussion_r1683521368
##
table/metadata.go:
##
@@ -156,6 +166,42 @@ type commonMetadata struct {
Refs map[string]SnapshotRef `json:"refs"`
}
+func (c *commonMeta
stevenzwu commented on code in PR #10526:
URL: https://github.com/apache/iceberg/pull/10526#discussion_r1683519816
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java:
##
@@ -426,30 +425,44 @@ private void commitOperation(
}
@Overr
stevenzwu commented on code in PR #10526:
URL: https://github.com/apache/iceberg/pull/10526#discussion_r1683518028
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java:
##
@@ -426,30 +425,44 @@ private void commitOperation(
}
@Overr
zeroshade commented on code in PR #108:
URL: https://github.com/apache/iceberg-go/pull/108#discussion_r1683516529
##
table/metadata.go:
##
@@ -156,6 +166,42 @@ type commonMetadata struct {
Refs map[string]SnapshotRef `json:"refs"`
}
+func (c *commonMeta
rdblue commented on code in PR #10691:
URL: https://github.com/apache/iceberg/pull/10691#discussion_r1683515066
##
core/src/main/java/org/apache/iceberg/util/ParallelIterable.java:
##
@@ -136,30 +169,33 @@ private boolean checkTasks() {
}
}
- return !close
rdblue commented on code in PR #10691:
URL: https://github.com/apache/iceberg/pull/10691#discussion_r1683506642
##
core/src/main/java/org/apache/iceberg/util/ParallelIterable.java:
##
@@ -88,16 +92,26 @@ private ParallelIterator(
@Override
public void close() {
Fokko commented on code in PR #108:
URL: https://github.com/apache/iceberg-go/pull/108#discussion_r1675971993
##
exprs.go:
##
@@ -538,11 +557,11 @@ func (up *unboundUnaryPredicate) Bind(schema *Schema,
caseSensitive bool) (Boole
// fast case optimizations
switch
stevenzwu commented on PR #10373:
URL: https://github.com/apache/iceberg/pull/10373#issuecomment-2237525207
> instead of normalizing non-cleanable failures to
CommitStateUnknownExcpetion now engines, in this case Spark will explicitly
handle CleanableFailure
@amogh-jahagirdar thanks
stevenzwu commented on PR #10373:
URL: https://github.com/apache/iceberg/pull/10373#issuecomment-2237511439
@amogh-jahagirdar sorry, I have been OOO for a while
> it may be better to go ahead and change the engines to explicitly handle
CleanableFailure. I'll look into this!
it
danielcweeks commented on code in PR #10711:
URL: https://github.com/apache/iceberg/pull/10711#discussion_r1683411769
##
api/src/main/java/org/apache/iceberg/io/SupportsRecoveryOperations.java:
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
Vanlightly commented on issue #10720:
URL: https://github.com/apache/iceberg/issues/10720#issuecomment-2237357673
Thanks, I'll take a look and see if I can repro in a test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
amogh-jahagirdar commented on issue #10720:
URL: https://github.com/apache/iceberg/issues/10720#issuecomment-2237339155
Thanks Jack, if you're looking for a place to write a test the
`TestConflictValidation` class
https://github.com/apache/iceberg/blob/main/spark/v3.5/spark-extensions/src/t
Vanlightly opened a new issue, #10720:
URL: https://github.com/apache/iceberg/issues/10720
### Apache Iceberg version
1.5.2 (latest release)
### Query engine
Spark
### Please describe the bug 🐞
I do a lot of formal verification of distributed systems and I h
sdd commented on code in PR #373:
URL: https://github.com/apache/iceberg-rust/pull/373#discussion_r1683284743
##
crates/iceberg/src/scan.rs:
##
@@ -389,12 +333,158 @@ impl FileScanStreamContext {
file_io,
bound_filter,
case_sensitive,
+
sdd commented on PR #373:
URL: https://github.com/apache/iceberg-rust/pull/373#issuecomment-2237194797
Thanks @odysa - I must be going crazy, I thought I tried that already but
you were right, that worked! 👍🏼
--
This is an automated message from the Apache Git Service.
To respond to the
sfc-gh-schen commented on PR #9804:
URL: https://github.com/apache/iceberg/pull/9804#issuecomment-2237119397
Hi, what is blocking from merging this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
vinjai opened a new pull request, #941:
URL: https://github.com/apache/iceberg-python/pull/941
Fixes: https://github.com/apache/iceberg-python/issues/306
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
karuppayya commented on code in PR #10288:
URL: https://github.com/apache/iceberg/pull/10288#discussion_r1683209368
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/NDVSketchGenerator.java:
##
@@ -0,0 +1,120 @@
+/*
+ * Licensed to the Apache Software Foundation
RussellSpitzer commented on PR #10624:
URL: https://github.com/apache/iceberg/pull/10624#issuecomment-2237069008
I think this is generally fine, but I do think the internal methods being
called should probably be renamed rather that continuing to use the "long" and
"double" method names.
odysa commented on PR #373:
URL: https://github.com/apache/iceberg-rust/pull/373#issuecomment-2236795680
@sdd `JoinHandle` in `Tokio` and `async-std` have different return types.
In
[Tokio](https://docs.rs/tokio/latest/src/tokio/runtime/task/join.rs.html#324)
```rs
impl Future for J
nastra merged PR #10718:
URL: https://github.com/apache/iceberg/pull/10718
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
snazy commented on code in PR #10711:
URL: https://github.com/apache/iceberg/pull/10711#discussion_r1682988347
##
api/src/main/java/org/apache/iceberg/io/SupportsRecoveryOperations.java:
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
RussellSpitzer commented on code in PR #10711:
URL: https://github.com/apache/iceberg/pull/10711#discussion_r1682980871
##
api/src/main/java/org/apache/iceberg/io/SupportsRecoveryOperations.java:
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
snazy opened a new pull request, #10719:
URL: https://github.com/apache/iceberg/pull/10719
Verifies the integrity of the `gradle-wrapper.jar` by checking the sha256
checksum and storing it locally. This also ensures that the
`gradle-wrapper.jar` automatically matches the Gradle version.
gaborkaszab commented on PR #10718:
URL: https://github.com/apache/iceberg/pull/10718#issuecomment-2236664941
> @gaborkaszab does the link work when you deploy the website locally as
described in https://github.com/apache/iceberg/blob/main/site/README.md?
Yes, I deployed the page loca
nastra commented on PR #10718:
URL: https://github.com/apache/iceberg/pull/10718#issuecomment-2236643716
@gaborkaszab does the link work when you deploy the website locally as
described in https://github.com/apache/iceberg/blob/main/site/README.md?
--
This is an automated message from the
gaborkaszab opened a new pull request, #10718:
URL: https://github.com/apache/iceberg/pull/10718
The link to the catalog properties was broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pvary commented on PR #10526:
URL: https://github.com/apache/iceberg/pull/10526#issuecomment-2236539203
@zhongqishang: Finally found time to start the upstream discussion:
https://lists.apache.org/thread/n5c85hd7psf2tmgych6scmynonscp2q4
--
This is an automated message from the Apache Git
ming95 commented on PR #9905:
URL: https://github.com/apache/iceberg/pull/9905#issuecomment-2236449363
> On #9784 you mentioned:
>
> > I think this is because hive and spark treat `timestamp` data type as
timestamp with time zone and the orc file format is also stored as orc
`tim
deniskuzZ commented on PR #2850:
URL: https://github.com/apache/iceberg/pull/2850#issuecomment-2236310737
> Finally I put together this in my head with the same issue in Hive:
>
> * https://issues.apache.org/jira/browse/HIVE-24445
>
> Wouldn't this solve both the issues?
>
nk1506 commented on issue #10707:
URL: https://github.com/apache/iceberg/issues/10707#issuecomment-2236218110
Hi @chenwyi2 , As I mentioned before if `write.metadata.metrics.default` has
been configured it won't honour
`write.metadata.metrics.max-inferred-column-defaults`. Since in your ca
findepi commented on PR #2890:
URL: https://github.com/apache/iceberg/pull/2890#issuecomment-2236196722
> In this patch, we only compare the pure path (remove the schema and
authority) when doing the `leftanti join`.
This sounds reasonable to me, but there is one caveat.
The table
findepi commented on code in PR #2890:
URL: https://github.com/apache/iceberg/pull/2890#discussion_r1682626007
##
spark/src/test/java/org/apache/iceberg/actions/MockFileSystem.java:
##
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mo
findepi commented on PR #10691:
URL: https://github.com/apache/iceberg/pull/10691#issuecomment-2236165774
> i will address first two now,
addressed. @rdblue PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
findepi commented on code in PR #10691:
URL: https://github.com/apache/iceberg/pull/10691#discussion_r1682603568
##
core/src/main/java/org/apache/iceberg/util/ParallelIterable.java:
##
@@ -20,65 +20,69 @@
import java.io.Closeable;
import java.io.IOException;
+import java.uti
Xuanwo closed issue #449: An interesting name proposed: riceberg
URL: https://github.com/apache/iceberg-rust/issues/449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
findepi commented on code in PR #10691:
URL: https://github.com/apache/iceberg/pull/10691#discussion_r1682590569
##
core/src/main/java/org/apache/iceberg/util/ParallelIterable.java:
##
@@ -88,16 +92,26 @@ private ParallelIterator(
@Override
public void close() {
findepi commented on PR #10691:
URL: https://github.com/apache/iceberg/pull/10691#issuecomment-2236063813
Thanks @rdblue for your thorough review.
I applied style fixes and outstanding items are
- resuming background tasks earlier
https://github.com/apache/iceberg/pull/10691#discus
jeesou commented on code in PR #10288:
URL: https://github.com/apache/iceberg/pull/10288#discussion_r1682528208
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/NDVSketchGenerator.java:
##
@@ -0,0 +1,120 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
findepi commented on code in PR #10691:
URL: https://github.com/apache/iceberg/pull/10691#discussion_r1682523817
##
core/src/main/java/org/apache/iceberg/util/ParallelIterable.java:
##
@@ -88,16 +92,26 @@ private ParallelIterator(
@Override
public void close() {
findepi commented on PR #10715:
URL: https://github.com/apache/iceberg/pull/10715#issuecomment-2236014654
thank you @amogh-jahagirdar !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
sdd commented on code in PR #373:
URL: https://github.com/apache/iceberg-rust/pull/373#discussion_r1682309951
##
crates/iceberg/src/scan.rs:
##
@@ -389,12 +333,158 @@ impl FileScanStreamContext {
file_io,
bound_filter,
case_sensitive,
+
97 matches
Mail list logo
