stevenzwu commented on code in PR #10526:
URL: https://github.com/apache/iceberg/pull/10526#discussion_r1683576927
##########
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/sink/TestIcebergFilesCommitter.java:
##########
@@ -204,7 +207,7 @@ public void testCommitTxn() throws Exception {
for (int i = 1; i <= 3; i++) {
RowData rowData = SimpleDataUtil.createRowData(i, "hello" + i);
DataFile dataFile = writeDataFile("data-" + i,
ImmutableList.of(rowData));
- harness.processElement(of(dataFile), ++timestamp);
+ harness.processElement(of(i, dataFile), ++timestamp);
Review Comment:
Iceberg coding style discourages use `++` for side effect like this.
I know this is not introduced by this PR. just of carrying over of the
existing code. so we don't need to fix it in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
