amogh-jahagirdar commented on PR #10544: URL: https://github.com/apache/iceberg/pull/10544#issuecomment-2237848340
Sorry for the late review on this @findepi , I was going through https://github.com/apache/iceberg/pull/10494 and trying to understand more about this path and saw this change as well. This particular change seems very safe to me since Caffeine already is threadsafe with respect to a given key. We don't a lock around the whole data structure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
