findepi commented on PR #10691: URL: https://github.com/apache/iceberg/pull/10691#issuecomment-2236063813
Thanks @rdblue for your thorough review. I applied style fixes and outstanding items are - resuming background tasks earlier https://github.com/apache/iceberg/pull/10691#discussion_r1681827634 - closing race https://github.com/apache/iceberg/pull/10691#discussion_r1682523817 - some jmh benchmarking? https://github.com/apache/iceberg/pull/10691#discussion_r1678296088 i will address first two now, the last is open question. cc @RussellSpitzer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
