findepi commented on PR #2890: URL: https://github.com/apache/iceberg/pull/2890#issuecomment-2236196722
> In this patch, we only compare the pure path (remove the schema and authority) when doing the `leftanti join`. This sounds reasonable to me, but there is one caveat. The table files may span multiple buckets, so comparing without schema and authority may not be quite correct. I think it's fine because - in worst case we don't clean some orphan files, which isn't unsafe - for tables spanning multiple locations, does orphan removal work at all? but someone else should confirm that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
