RussellSpitzer commented on PR #10624: URL: https://github.com/apache/iceberg/pull/10624#issuecomment-2237069008
I think this is generally fine, but I do think the internal methods being called should probably be renamed rather that continuing to use the "long" and "double" method names. for example having a "wholeNumberOrderedBytes" and "floatingPointOrderedBytes" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
